Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Commit 4480edf

Browse files
Address code review: descriptive exception message, remove unnecessary cast
Co-authored-by: vitorhugo-java <65777252+vitorhugo-java@users.noreply.github.com>
1 parent 97d4a1e commit 4480edf

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/main/java/com/espacogeek/geek/controllers/MediaController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ public class MediaController {
3636
private final SeasonRepository seasonRepository;
3737
private final AlternativeTitlesRepository alternativeTitlesRepository;
3838
@SuppressWarnings("rawtypes")
39-
private final ExternalReferenceRepository externalReferenceRepository;
40-
private final MediaRepository mediaRepository;
39+
private final ExternalReferenceRepository externalReferenceRepository; private final MediaRepository mediaRepository;
4140

4241
/**
4342
* Finds a MediaModel object by its ID.
@@ -229,7 +228,8 @@ public Map<MediaModel, Set<ExternalReferenceModel>> externalReference(List<Media
229228
.collect(Collectors.toMap(MediaModel::getId, m -> m));
230229
Map<MediaModel, Set<ExternalReferenceModel>> result = medias.stream()
231230
.collect(Collectors.toMap(m -> m, m -> new HashSet<>()));
232-
for (ExternalReferenceModel ref : (List<ExternalReferenceModel>) externalReferenceRepository.findAllByMediaIn(medias)) {
231+
List<ExternalReferenceModel> refs = externalReferenceRepository.findAllByMediaIn(medias);
232+
for (ExternalReferenceModel ref : refs) {
233233
MediaModel source = sourceById.get(ref.getMedia().getId());
234234
if (source != null) {
235235
result.get(source).add(ref);

src/main/java/com/espacogeek/geek/data/impl/GenericMediaDataControllerImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ public List<MediaModel> searchMedia(String search, MediaApi mediaApi, TypeRefere
285285
result.add(media);
286286

287287
} catch (MediaAlreadyExist e) {
288-
media = mediaService.findByReferenceAndTypeReference(mediaSearch.getExternalReference().iterator().next(), typeReference).orElseThrow();
288+
media = mediaService.findByReferenceAndTypeReference(mediaSearch.getExternalReference().iterator().next(), typeReference).orElseThrow(() -> new com.espacogeek.geek.exception.GenericException("Media not found for the given external reference"));
289289

290290
result.add(media);
291291
}

0 commit comments

Comments
 (0)