Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Commit dddb4ff

Browse files
Copilotvitorhugo-java
Copilot
and
vitorhugo-java
committed
Fix all 43 Qodana static analysis warnings
Co-authored-by: vitorhugo-java <65777252+vitorhugo-java@users.noreply.github.com>
1 parent b146d2a commit dddb4ff

14 files changed

Lines changed: 39 additions & 72 deletions

‎src/main/java/com/espacogeek/geek/config/JwtConfig.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ private List<String> buildRolesList(UserModel user) {
7979
if (raw != null && !raw.isBlank()) {
8080
String[] parts = raw.replaceAll("\\s", "").split(",");
8181
rolesList.addAll(Arrays.stream(parts)
82-
.map(s -> s == null ? null : s.trim())
83-
.filter(s -> s != null && !s.isBlank())
82+
.filter(s -> !s.isBlank())
8483
.map(s -> {
8584
if (s.startsWith("ROLE_") || s.startsWith("ID_")) return s;
8685
return "ROLE_" + s;

‎src/main/java/com/espacogeek/geek/controllers/MediaController.java‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public MediaModel getMediaById(@Argument(name = "id") Integer id) {
6262
public MediaPage getMovie(@Argument(name = "id") Integer id, @Argument(name = "name") String name, DataFetchingEnvironment dataFetchingEnvironment) {
6363
name = name == null ? null : name.trim();
6464

65-
if (name == null && id == null || name == "" && id == null) {
65+
if (id == null && (name == null || name.isEmpty())) {
6666
return new MediaPage();
6767
}
6868

@@ -81,7 +81,7 @@ public MediaPage getMovie(@Argument(name = "id") Integer id, @Argument(name = "n
8181
public MediaPage getSerie(@Argument(name = "id") Integer id, @Argument(name = "name") String name, DataFetchingEnvironment dataFetchingEnvironment) {
8282
name = name == null ? null : name.trim();
8383

84-
if (name == null && id == null || name == "" && id == null) {
84+
if (id == null && (name == null || name.isEmpty())) {
8585
return new MediaPage();
8686
}
8787

@@ -100,7 +100,7 @@ public MediaPage getSerie(@Argument(name = "id") Integer id, @Argument(name = "n
100100
public MediaPage getGame(@Argument(name = "id") Integer id, @Argument(name = "name") String name, DataFetchingEnvironment dataFetchingEnvironment) {
101101
name = name == null ? null : name.trim();
102102

103-
if (name == null && id == null || name == "" && id == null) {
103+
if (id == null && (name == null || name.isEmpty())) {
104104
return new MediaPage();
105105
}
106106

@@ -117,11 +117,10 @@ public MediaPage getGame(@Argument(name = "id") Integer id, @Argument(name = "na
117117
*/
118118
@QueryMapping(name = "vn")
119119
public MediaPage getVisualNovel(@Argument(name = "id") Integer id, @Argument(name = "name") String name, DataFetchingEnvironment dataFetchingEnvironment) {
120-
MediaPage response = new MediaPage();
121120
name = name == null ? null : name.trim();
122121

123-
if (name == null && id == null || name == "" && id == null) {
124-
return response;
122+
if (id == null && (name == null || name.isEmpty())) {
123+
return new MediaPage();
125124
}
126125

127126
return this.mediaService.findVisualNovelByIdOrName(id, name, MediaUtils.getPageable(dataFetchingEnvironment));
@@ -138,7 +137,7 @@ public MediaPage getVisualNovel(@Argument(name = "id") Integer id, @Argument(nam
138137
public MediaPage getAnime(@Argument(name = "id") Integer id, @Argument(name = "name") String name, DataFetchingEnvironment dataFetchingEnvironment) {
139138
name = name == null ? null : name.trim();
140139

141-
if (name == null && id == null || name == "" && id == null) {
140+
if (id == null && (name == null || name.isEmpty())) {
142141
return new MediaPage();
143142
}
144143

‎src/main/java/com/espacogeek/geek/controllers/UserController.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ public String editPasswordUserLogged(Authentication authentication, @Argument(na
183183

184184
Integer userId = UserUtils.getUserID(authentication);
185185

186-
UserModel userLogged = userService.findById(Integer.valueOf(userId)).get();
186+
UserModel userLogged = userService.findById(userId).orElseThrow(() -> new GenericException(HttpStatus.NOT_FOUND.toString()));
187187
boolean resultPassword = BCrypt.verifyer().verify(actualPassword.toCharArray(), userLogged.getPassword()).verified;
188188

189189
if (resultPassword) {
@@ -205,11 +205,11 @@ public String deleteUserLogged(Authentication authentication, @Argument(name = "
205205

206206
Integer userId = UserUtils.getUserID(authentication);
207207

208-
UserModel userLogged = userService.findById(userId).get();
208+
UserModel userLogged = userService.findById(userId).orElseThrow(() -> new GenericException(HttpStatus.NOT_FOUND.toString()));
209209
boolean resultPassword = BCrypt.verifyer().verify(password.toCharArray(), userLogged.getPassword()).verified;
210210

211211
if (resultPassword) {
212-
userService.deleteById(Integer.valueOf(userId));
212+
userService.deleteById(userId);
213213
return HttpStatus.OK.toString();
214214
}
215215

@@ -222,7 +222,7 @@ public String editUsernameUserLogged(Authentication authentication, @Argument(na
222222

223223
Integer userId = UserUtils.getUserID(authentication);
224224

225-
UserModel userLogged = userService.findById(userId).get();
225+
UserModel userLogged = userService.findById(userId).orElseThrow(() -> new GenericException(HttpStatus.NOT_FOUND.toString()));
226226
boolean resultPassword = BCrypt.verifyer().verify(password.toCharArray(), userLogged.getPassword()).verified;
227227

228228
if (resultPassword) {
@@ -240,7 +240,7 @@ public String editEmailUserLogged(Authentication authentication, @Argument(name
240240

241241
Integer userId = UserUtils.getUserID(authentication);
242242

243-
UserModel userLogged = userService.findById(userId).get();
243+
UserModel userLogged = userService.findById(userId).orElseThrow(() -> new GenericException(HttpStatus.NOT_FOUND.toString()));
244244
boolean resultPassword = BCrypt.verifyer().verify(password.toCharArray(), userLogged.getPassword()).verified;
245245

246246
if (resultPassword) {

‎src/main/java/com/espacogeek/geek/data/api/impl/MovieAPIImpl.java‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public InputStream updateTitlesStream() {
7777
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
7878
@Override
7979
public MediaModel getDetails(Integer id) {
80-
MovieDb movieDb = new MovieDb();
80+
MovieDb movieDb;
8181
try {
8282
movieDb = api.getDetails(id, "en-US", MovieAppendToResponse.EXTERNAL_IDS, MovieAppendToResponse.ALTERNATIVE_TITLES, MovieAppendToResponse.IMAGES, MovieAppendToResponse.VIDEOS);
8383
} catch (TmdbException e) {
@@ -111,9 +111,7 @@ public MediaModel getDetails(Integer id) {
111111
}
112112

113113
public ExternalReferenceModel getTrailer(MovieDb movieDb) {
114-
ExternalReferenceModel trailers = null;
115-
116-
trailers = movieDb.getVideos().getResults().stream().filter(video -> video.getType().equals("Trailer"))
114+
ExternalReferenceModel trailers = movieDb.getVideos().getResults().stream().filter(video -> video.getType().equals("Trailer"))
117115
.findFirst().map(video -> new ExternalReferenceModel(null, video.getKey(), null, typeReferenceService.findById(MediaDataController.ExternalReferenceType.YT.getId()).get()))
118116
.orElse(null);
119117

@@ -125,7 +123,7 @@ public ExternalReferenceModel getTrailer(MovieDb movieDb) {
125123
*/
126124
@Override
127125
public MediaModel getArtwork(Integer id) {
128-
Images rawArtwork = new Images();
126+
Images rawArtwork;
129127
try {
130128
rawArtwork = api.getImages(id, "en");
131129
} catch (TmdbException e) {
@@ -160,7 +158,7 @@ public List<Keyword> getKeyword(Integer id) {
160158
@Override
161159
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
162160
public List<AlternativeTitleModel> getAlternativeTitles(Integer id) {
163-
List<AlternativeTitle> rawAlternativeTitles = new ArrayList<>();
161+
List<AlternativeTitle> rawAlternativeTitles;
164162
try {
165163
rawAlternativeTitles = api.getAlternativeTitles(id, "us").getTitles();
166164
} catch (TmdbException e) {
@@ -186,7 +184,7 @@ private List<AlternativeTitleModel> formatAlternativeTitles(List<AlternativeTitl
186184
@Override
187185
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
188186
public List<ExternalReferenceModel> getExternalReference(Integer id) {
189-
ExternalIds rawExternalReferences = new ExternalIds();
187+
ExternalIds rawExternalReferences;
190188
try {
191189
rawExternalReferences = api.getExternalIds(id);
192190
} catch (TmdbException e) {
@@ -214,7 +212,7 @@ private List<ExternalReferenceModel> formatExternalReference(ExternalIds rawExte
214212
@Override
215213
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
216214
public List<GenreModel> getGenre(Integer id) {
217-
MovieDb movieDb = new MovieDb();
215+
MovieDb movieDb;
218216
try {
219217
movieDb = api.getDetails(id, "en-US");
220218
} catch (TmdbException e) {
@@ -237,9 +235,7 @@ private List<GenreModel> formatGenre(List<Genre> rawGenres) {
237235
var genre = rawStringGenres.get(i);
238236
if (genre.contains("&")) {
239237
for (String genreDivided : genre.split("&")) {
240-
genreDivided.replace("&", "");
241-
genreDivided = genreDivided.strip();
242-
newRawGenres.add(genreDivided);
238+
newRawGenres.add(genreDivided.strip());
243239
}
244240
}
245241
}

‎src/main/java/com/espacogeek/geek/data/api/impl/QuoteApiImpl.java‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void init() {
4949
@Override
5050
public QuoteModel getRandomQuote() {
5151
var client = new OkHttpClient().newBuilder().build();
52-
Request request = null;
52+
Request request;
5353
try {
5454
request = new Request.Builder()
5555
.url(URL_QUOTE)
@@ -62,21 +62,13 @@ public QuoteModel getRandomQuote() {
6262
throw new GenericException("Quote not found");
6363
}
6464

65-
Response response = null;
66-
try {
67-
response = client.newCall(request).execute();
68-
} catch (IOException e) {
69-
log.error("Error executing request for Quote API: {}", e.getMessage());
70-
throw new GenericException("Quote not found");
71-
}
72-
7365
var parser = new JSONParser();
7466
var jsonArray = new JSONArray();
75-
try {
67+
try (Response response = client.newCall(request).execute()) {
7668
assert response.body() != null;
7769
jsonArray = (JSONArray) parser.parse(response.body().string());
7870
} catch (ParseException | IOException e) {
79-
log.error("Error parsing response from Quote API: {}", e.getMessage());
71+
log.error("Error executing or parsing response from Quote API: {}", e.getMessage());
8072
throw new GenericException("Quote not found");
8173
}
8274

‎src/main/java/com/espacogeek/geek/data/api/impl/TvSeriesApiImpl.java‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public InputStream updateTitlesStream() {
8282
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
8383
@Override
8484
public MediaModel getDetails(Integer id) {
85-
TvSeriesDb rawSerieDetails = new TvSeriesDb();
85+
TvSeriesDb rawSerieDetails;
8686
try {
8787
rawSerieDetails = api.getDetails(id, "en-US", TvSeriesAppendToResponse.EXTERNAL_IDS, TvSeriesAppendToResponse.ALTERNATIVE_TITLES, TvSeriesAppendToResponse.IMAGES, TvSeriesAppendToResponse.VIDEOS);
8888
} catch (TmdbException e) {
@@ -117,9 +117,7 @@ public MediaModel getDetails(Integer id) {
117117
}
118118

119119
public ExternalReferenceModel getTrailer(TvSeriesDb rawSerieDetails) {
120-
ExternalReferenceModel trailers = null;
121-
122-
trailers = rawSerieDetails.getVideos().getResults().stream().filter(video -> video.getType().equals("Trailer"))
120+
ExternalReferenceModel trailers = rawSerieDetails.getVideos().getResults().stream().filter(video -> video.getType().equals("Trailer"))
123121
.findFirst().map(video -> new ExternalReferenceModel(null, video.getKey(), null,
124122
typeReferenceService.findById(MediaDataController.ExternalReferenceType.YT.getId()).get()))
125123
.orElse(null);
@@ -133,7 +131,7 @@ public ExternalReferenceModel getTrailer(TvSeriesDb rawSerieDetails) {
133131
@Override
134132
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
135133
public MediaModel getArtwork(Integer id) {
136-
Images rawArtwork = new Images();
134+
Images rawArtwork;
137135
try {
138136
rawArtwork = api.getImages(id, "");
139137
} catch (TmdbException e) {
@@ -167,7 +165,7 @@ public List<Keyword> getKeyword(Integer id) {
167165
@Override
168166
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
169167
public List<AlternativeTitleModel> getAlternativeTitles(Integer id) {
170-
List<AlternativeTitle> rawAlternativeTitles = new ArrayList<>();
168+
List<AlternativeTitle> rawAlternativeTitles;
171169
try {
172170
rawAlternativeTitles = api.getAlternativeTitles(id).getResults();
173171
} catch (TmdbException e) {
@@ -192,7 +190,7 @@ private List<AlternativeTitleModel> formatAlternativeTitles(List<AlternativeTitl
192190
@Override
193191
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
194192
public List<ExternalReferenceModel> getExternalReference(Integer id) {
195-
ExternalIds rawExternalReferences = new ExternalIds();
193+
ExternalIds rawExternalReferences;
196194
try {
197195
rawExternalReferences = api.getExternalIds(id);
198196
} catch (TmdbException e) {
@@ -225,7 +223,7 @@ private List<ExternalReferenceModel> formatExternalReference(ExternalIds rawExte
225223
@Override
226224
@Retryable(maxAttempts = 2, backoff = @Backoff(delay = 2000), retryFor = com.espacogeek.geek.exception.RequestException.class)
227225
public List<GenreModel> getGenre(Integer id) {
228-
TvSeriesDb rawSerieDetails = new TvSeriesDb();
226+
TvSeriesDb rawSerieDetails;
229227
try {
230228
rawSerieDetails = api.getDetails(id, "en-US");
231229
} catch (TmdbException e) {
@@ -246,9 +244,7 @@ private List<GenreModel> formatGenre(List<Genre> rawGenres) {
246244
for (String genre : rawStringGenres) {
247245
if (genre.contains("&")) {
248246
for (String genreDivided : genre.split("&")) {
249-
genreDivided = genreDivided.replace("&", "");
250-
genreDivided = genreDivided.strip();
251-
newRawGenres.add(genreDivided);
247+
newRawGenres.add(genreDivided.strip());
252248
}
253249
}
254250
}

‎src/main/java/com/espacogeek/geek/data/impl/GenericMediaDataControllerImpl.java‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,12 +274,9 @@ public List<MediaModel> searchMedia(String search, MediaApi mediaApi, TypeRefere
274274
var result = new ArrayList<MediaModel>();
275275

276276
for (MediaModel mediaSearch : rawMediaSearchList) {
277-
var media = new MediaModel();
278-
media.setMediaCategory(mediaCategory);
279-
277+
MediaModel media;
280278
try {
281279
media = createMediaIfNotExistAndIfExistReturnIt(mediaSearch, typeReference);
282-
media = mediaSearch;
283280

284281
if (media != null) {
285282
updateExternalReferences(media, mediaSearch, typeReference, mediaApi);

‎src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,6 @@ else if (isUndefined)
124124

125125
media.setName(json.get("original_title").toString());
126126

127-
if (externalReferenceExisted.isPresent()) {
128-
media.setId(externalReferenceExisted.get().getMedia().getId());
129-
externalReference.setId(externalReferenceExisted.get().getId());
130-
}
131-
132127
var mediaSaved = mediaService.save(media);
133128

134129
externalReference.setMedia(mediaSaved);

‎src/main/java/com/espacogeek/geek/data/impl/SerieControllerImpl.java‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,6 @@ private void updateTvSeries() {
9393

9494
media.setName(json.get("original_name").toString());
9595

96-
if (externalReferenceExisted.isPresent()) {
97-
media.setId(externalReferenceExisted.get().getMedia().getId());
98-
externalReference.setId(externalReferenceExisted.get().getId());
99-
}
100-
10196
var mediaSaved = mediaService.save(media);
10297

10398
externalReference.setMedia(mediaSaved);

‎src/main/java/com/espacogeek/geek/metrics/GraphQLMetricsInstrumentation.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public static String extractOperationName(String query) {
2828
}
2929

3030
// Se não encontrou, tenta extrair a primeira palavra-chave GraphQL
31-
pattern = java.util.regex.Pattern.compile("(\\w+)\\s*(?:\\(|\\{)");
31+
pattern = java.util.regex.Pattern.compile("(\\w+)\\s*[({]");
3232
matcher = pattern.matcher(query);
3333
if (matcher.find()) {
3434
return matcher.group(1);

0 commit comments

Comments
 (0)