[Dash] Deprecate traditional Flex Counter support#42
Closed
vivekrnv wants to merge 2 commits into
Closed
Conversation
vivekrnv
force-pushed
the
refactor_dash_fc
branch
5 times, most recently
from
64458bf to
8856639
Compare
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
vivekrnv
force-pushed
the
refactor_dash_fc
branch
from
8856639 to
de62c9f
Compare
stephenxs
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Simplify the logic by removing Timers etc associated with Traditional Approach for DASH counters.
Refactor Dash Meter FC by moving the logic into DashOrch since pre-requisites for creating ENI/Meter counters is the same and is dependent only on ENI object creation/deletion
Why I did it
Traditional counters approach is not used for DASH related counters on DPU platforms but the code to support exists and making the code un-necessarily complex and slightly less performant because of 2 timers
How I verified it
UT's
Creating, deleting ENI and observing counters are created
Details if related