[Dash] Update ENI Forward Orch to handle new DPU Table schema#44
Closed
vivekrnv wants to merge 3 commits into
Closed
[Dash] Update ENI Forward Orch to handle new DPU Table schema#44vivekrnv wants to merge 3 commits into
vivekrnv wants to merge 3 commits into
Conversation
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
vivekrnv
changed the title
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
vivekrnv
force-pushed
the
fix_enifwd_schema
branch
from
9b8d478 to
2b91a59
Compare
Yakiv-Huryk
reviewed
Sep 22, 2025
| SWSS_LOG_WARN("Multiple Local Endpoints for the ENI %s found, proceeding with %" PRIu64 "" , | ||
| mac_.to_string().c_str(), local_endpoint); | ||
| SWSS_LOG_WARN("Multiple Local Endpoints for the ENI %s found, proceeding with %s", | ||
| mac_.to_string().c_str(), local_endpoint.c_str()); |
There was a problem hiding this comment.
The local_endpoint can be an empty string here, right? If so, this will crash.
There was a problem hiding this comment.
after another look, it seems that it's not possible to have an empty string there
Owner
Author
There was a problem hiding this comment.
Yeah, this'll be hit only for multiple local endpoints case
Yakiv-Huryk
reviewed
Sep 22, 2025
| } | ||
|
|
||
| bool EniInfo::findLocalEp(uint64_t& local_endpoint) const | ||
| bool EniInfo::findLocalEp(std::string& local_endpoint) |
Owner
Author
There was a problem hiding this comment.
Was getting a compiler error here when i apply const and use std::string&, will see if i can fix it
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Yakiv-Huryk
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
Here is the latest schema:
https://github.com/sonic-net/SONiC/blob/91c3d94be67c96b2cba7fa8ce43bfff540638971/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md#2111-dpu--vdpu-definitions
https://github.com/sonic-net/SONiC/blob/91c3d94be67c96b2cba7fa8ce43bfff540638971/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md#2321-dash_eni_forward_table
How I verified it
Ran Tests
Details if related