Skip to content

Commit b37ddf9

Browse files
committed
test(snapshots): migrate shim cases to the PTY snapshot suite
Migrate 7 of the 11 legacy `shim-*` global snap-test cases (node/npm/pnpm shim behavior) to the PTY snapshot suite: - shim-inherits-parent-{dev-engines-runtime,engines-node,node-version} - shim-npm-uses-package-manager-version - shim-npm-ignores-mismatched-package-manager - shim-pnpm-uses-project-node-version - shim-recursive-npm-run The `test "$(npm --version)" = X` version assertions become direct `npm`/`npx --version` steps whose pinned output is the snapshot; `npx` is added to the runner program allow-list (resolved from the case PATH, so the vp-managed shim wins). Left in the legacy tree because they depend on shell features the PTY runner intentionally does not provide: shim-corepack-bundled (corepack shim resolution differs without the `vp remove -g corepack` isolation), shim-corepack-enable-install-directory (fake runtime + `$(pwd)`/PATH overrides), shim-npm-downloads-uncached-package-manager-version (`$VP_HOME` path references + deliberate download path), shim-recursive-package-binary (invokes an arbitrary installed binary).
1 parent 576fd3b commit b37ddf9

44 files changed

Lines changed: 230 additions & 115 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/cli/snap-tests-global/shim-inherits-parent-dev-engines-runtime/package.json renamed to crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/shim_inherits_parent_dev_engines_runtime/package.json

File renamed without changes.

packages/cli/snap-tests-global/shim-inherits-parent-dev-engines-runtime/packages/app/package.json renamed to crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/shim_inherits_parent_dev_engines_runtime/packages/app/package.json

File renamed without changes.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
[[case]]
2+
name = "shim_inherits_parent_dev_engines_runtime"
3+
vp = "global"
4+
skip-platforms = ["windows"]
5+
steps = [
6+
{ argv = ["vp", "env", "exec", "node", "-v"], comment = "Root: uses devEngines.runtime directly", continue-on-failure = true },
7+
{ argv = ["vp", "env", "exec", "node", "-v"], cwd = "packages/app", comment = "Sub-package: inherits parent devEngines.runtime", continue-on-failure = true },
8+
{ argv = ["vpt", "stat-file", "packages/app/.node-version", "--assert-not", "file"], comment = "Verify no .node-version created in sub-package", continue-on-failure = true },
9+
]
Lines changed: 25 additions & 0 deletions

packages/cli/snap-tests-global/shim-inherits-parent-engines-node/package.json renamed to crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/shim_inherits_parent_engines_node/package.json

File renamed without changes.

packages/cli/snap-tests-global/shim-inherits-parent-engines-node/packages/app/package.json renamed to crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/shim_inherits_parent_engines_node/packages/app/package.json

File renamed without changes.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
[[case]]
2+
name = "shim_inherits_parent_engines_node"
3+
vp = "global"
4+
skip-platforms = ["windows"]
5+
steps = [
6+
{ argv = ["vp", "env", "exec", "node", "-v"], comment = "Root: uses engines.node directly", continue-on-failure = true },
7+
{ argv = ["vp", "env", "exec", "node", "-v"], cwd = "packages/app", comment = "Sub-package: inherits parent engines.node", continue-on-failure = true },
8+
{ argv = ["vpt", "stat-file", "packages/app/.node-version", "--assert-not", "file"], comment = "Verify no .node-version created in sub-package", continue-on-failure = true },
9+
]
Lines changed: 25 additions & 0 deletions

packages/cli/snap-tests-global/shim-inherits-parent-node-version/.node-version renamed to crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/shim_inherits_parent_node_version/.node-version

File renamed without changes.

packages/cli/snap-tests-global/shim-inherits-parent-node-version/package.json renamed to crates/vite_cli_snapshots/tests/cli_snapshots/fixtures/shim_inherits_parent_node_version/package.json

File renamed without changes.

0 commit comments

Comments
 (0)