Skip to content

Commit f4cc891

Browse files
committed
ci(snapshots): run the Linux PTY snapshot leg on ubuntu-latest
The namespace-profile-linux-x64-default runner wedges the PTY suite: vp processes there do not exit and grandchildren keep the PTY slave open, so the exit-wait hangs and the job is cancelled. The exact same code runs clean on macOS Namespace (203/203 in 76s) and on GitHub-hosted Windows, so the fault is the runner, not the tests. Move the Linux leg to GitHub-hosted ubuntu-latest, mirroring the ConPTY move that already keeps the Windows leg off Namespace.
1 parent 946d158 commit f4cc891

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1046,7 +1046,13 @@ jobs:
10461046
fail-fast: false
10471047
matrix:
10481048
include:
1049-
- os: namespace-profile-linux-x64-default
1049+
# GitHub-hosted, not namespace-profile-linux-x64-default: the
1050+
# Namespace Linux runner wedges the PTY suite (vp processes there do
1051+
# not exit / grandchildren keep the PTY slave open), while the exact
1052+
# same code runs clean on macOS Namespace and GitHub-hosted Windows.
1053+
# This is the Linux analog of the ConPTY move that keeps
1054+
# cli-snapshot-test-windows on a GitHub-hosted runner.
1055+
- os: ubuntu-latest
10501056
target: x86_64-unknown-linux-gnu
10511057
- os: namespace-profile-mac-default
10521058
target: aarch64-apple-darwin

0 commit comments

Comments
 (0)