From 3198cd971aa8661a283cb94b756c6404a03e7485 Mon Sep 17 00:00:00 2001 From: MK Date: Wed, 24 Sep 2025 15:52:23 +0800 Subject: [PATCH 1/2] fix(task): vite dev support options --- crates/vite_task/src/execute.rs | 2 -- crates/vite_task/src/lib.rs | 2 +- crates/vite_task/src/schedule.rs | 7 +++++++ .../cli/snap-tests/command-dev-with-port/package.json | 2 ++ packages/cli/snap-tests/command-dev-with-port/snap.txt | 2 ++ packages/cli/snap-tests/command-dev-with-port/steps.json | 8 ++++++++ 6 files changed, 20 insertions(+), 3 deletions(-) create mode 100644 packages/cli/snap-tests/command-dev-with-port/package.json create mode 100644 packages/cli/snap-tests/command-dev-with-port/snap.txt create mode 100644 packages/cli/snap-tests/command-dev-with-port/steps.json diff --git a/crates/vite_task/src/execute.rs b/crates/vite_task/src/execute.rs index df1c763033..db1c59a684 100644 --- a/crates/vite_task/src/execute.rs +++ b/crates/vite_task/src/execute.rs @@ -311,8 +311,6 @@ impl TaskEnvs { ]; *env_path = join_paths(node_modules_bin_paths.into_iter().chain(paths))?.into(); - tracing::debug!("all_envs: {:?}", all_envs); - Ok(Self { all_envs, envs_without_pass_through }) } } diff --git a/crates/vite_task/src/lib.rs b/crates/vite_task/src/lib.rs index e8529a9891..8c5c037bc3 100644 --- a/crates/vite_task/src/lib.rs +++ b/crates/vite_task/src/lib.rs @@ -116,7 +116,7 @@ pub enum Commands { args: Vec, }, Dev { - #[clap(last = true)] + #[arg(allow_hyphen_values = true, trailing_var_arg = true)] /// Arguments to pass to vite dev args: Vec, }, diff --git a/crates/vite_task/src/schedule.rs b/crates/vite_task/src/schedule.rs index 8ddde3cf5d..56001874e4 100644 --- a/crates/vite_task/src/schedule.rs +++ b/crates/vite_task/src/schedule.rs @@ -223,6 +223,13 @@ async fn get_cached_or_execute<'a>( let executed_task = execute_task(execution_id, &task.resolved_command, base_dir).await?; let exit_status = executed_task.exit_status; + tracing::debug!( + "executed command `{}` finished, duration: {:?}, skip_cache: {}, {}", + task.resolved_command.fingerprint.command, + executed_task.duration, + skip_cache, + exit_status + ); if !skip_cache && exit_status.success() { let cached_task = CommandCacheValue::create(executed_task, fs, base_dir)?; cache.update(&task, cached_task).await?; diff --git a/packages/cli/snap-tests/command-dev-with-port/package.json b/packages/cli/snap-tests/command-dev-with-port/package.json new file mode 100644 index 0000000000..2c63c08510 --- /dev/null +++ b/packages/cli/snap-tests/command-dev-with-port/package.json @@ -0,0 +1,2 @@ +{ +} diff --git a/packages/cli/snap-tests/command-dev-with-port/snap.txt b/packages/cli/snap-tests/command-dev-with-port/snap.txt new file mode 100644 index 0000000000..ac9c44877b --- /dev/null +++ b/packages/cli/snap-tests/command-dev-with-port/snap.txt @@ -0,0 +1,2 @@ +> vite dev --port 12312312312 2>&1 | grep RangeError # dev server with wrong port throw error +RangeError [ERR_SOCKET_BAD_PORT]: options.port should be >= 0 and < 65536. Received type number (12312312312). diff --git a/packages/cli/snap-tests/command-dev-with-port/steps.json b/packages/cli/snap-tests/command-dev-with-port/steps.json new file mode 100644 index 0000000000..9a7c6cd193 --- /dev/null +++ b/packages/cli/snap-tests/command-dev-with-port/steps.json @@ -0,0 +1,8 @@ +{ + "env": { + "VITE_DISABLE_AUTO_INSTALL": "1" + }, + "commands": [ + "vite dev --port 12312312312 2>&1 | grep RangeError # dev server with wrong port throw error" + ] +} From a1cbc544d0de50665e26b24a4ae77390315a6e41 Mon Sep 17 00:00:00 2001 From: "MK (fengmk2)" Date: Wed, 24 Sep 2025 16:11:18 +0800 Subject: [PATCH 2/2] Update steps.json --- packages/cli/snap-tests/command-dev-with-port/snap.txt | 2 +- packages/cli/snap-tests/command-dev-with-port/steps.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/cli/snap-tests/command-dev-with-port/snap.txt b/packages/cli/snap-tests/command-dev-with-port/snap.txt index ac9c44877b..44d205d25d 100644 --- a/packages/cli/snap-tests/command-dev-with-port/snap.txt +++ b/packages/cli/snap-tests/command-dev-with-port/snap.txt @@ -1,2 +1,2 @@ -> vite dev --port 12312312312 2>&1 | grep RangeError # dev server with wrong port throw error +> vite dev --port 12312312312 2>&1 | grep RangeError # intentionally use an invalid port (exceeds 0-65535) to trigger RangeError RangeError [ERR_SOCKET_BAD_PORT]: options.port should be >= 0 and < 65536. Received type number (12312312312). diff --git a/packages/cli/snap-tests/command-dev-with-port/steps.json b/packages/cli/snap-tests/command-dev-with-port/steps.json index 9a7c6cd193..586d530540 100644 --- a/packages/cli/snap-tests/command-dev-with-port/steps.json +++ b/packages/cli/snap-tests/command-dev-with-port/steps.json @@ -3,6 +3,6 @@ "VITE_DISABLE_AUTO_INSTALL": "1" }, "commands": [ - "vite dev --port 12312312312 2>&1 | grep RangeError # dev server with wrong port throw error" + "vite dev --port 12312312312 2>&1 | grep RangeError # intentionally use an invalid port (exceeds 0-65535) to trigger RangeError" ] }