From 0ff213b5f714d2e7077cfe6d29192237c3fa4dd8 Mon Sep 17 00:00:00 2001 From: karthic Date: Sat, 14 Nov 2026 07:37:03 +0530 Subject: [PATCH] Insert the page title literally into `titleTemplate`, closes #824. Co-Authored-By: Claude Opus 5.5 --- packages/void/src/pages/head.ts | 2 +- packages/void/test/unit/pages-head.test.ts | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/void/src/pages/head.ts b/packages/void/src/pages/head.ts index 389752337..94787c85d 100644 --- a/packages/void/src/pages/head.ts +++ b/packages/void/src/pages/head.ts @@ -37,7 +37,7 @@ export function resolveHead( const title = pageHead?.title ?? middlewareHead?.title ?? configHead?.title; if (title !== undefined) { const template = middlewareHead?.titleTemplate ?? configHead?.titleTemplate; - result.title = template ? template.replace('%s', title) : title; + result.title = template ? template.replace('%s', () => title) : title; } // Meta entries dedupe by charset/property/name; later layers win but keep diff --git a/packages/void/test/unit/pages-head.test.ts b/packages/void/test/unit/pages-head.test.ts index 8a6021269..0ba6f2656 100644 --- a/packages/void/test/unit/pages-head.test.ts +++ b/packages/void/test/unit/pages-head.test.ts @@ -71,6 +71,13 @@ describe('resolveHead', () => { expect(resolveHead(config, middleware, page)?.title).toBe('Users'); }); + it('inserts a title containing `$` replacement patterns as written', () => { + const middleware: HeadConfig = { titleTemplate: '%s | Admin' }; + for (const title of ['A $& B', 'Price $` x', "x $' y", 'Tom $$ Jerry', '$1 off']) { + expect(resolveHead(undefined, middleware, { title })?.title).toBe(`${title} | Admin`); + } + }); + it('does not emit titleTemplate in the resolved head', () => { const middleware: HeadConfig = { titleTemplate: '%s | Admin' }; const page: HeadDescriptor = { title: 'Users' };