diff --git a/platform/packages/api/test/integration/deploy-direct-r2.test.ts b/platform/packages/api/test/integration/deploy-direct-r2.test.ts index fc415b80d..c91e4bad1 100644 --- a/platform/packages/api/test/integration/deploy-direct-r2.test.ts +++ b/platform/packages/api/test/integration/deploy-direct-r2.test.ts @@ -19,7 +19,6 @@ import { afterEach, vi, } from 'vite-plus/test'; -import { computeAssetHash } from '../../src/assets.ts'; import { cancelDeployment } from '../../src/db.ts'; import app from '../../src/index.ts'; import * as projectIngress from '../../src/project-ingress.ts'; diff --git a/platform/packages/dispatch/src/index.ts b/platform/packages/dispatch/src/index.ts index bec774c5c..5007aa400 100644 --- a/platform/packages/dispatch/src/index.ts +++ b/platform/packages/dispatch/src/index.ts @@ -29,7 +29,6 @@ import { SHARED_CACHE_POLICY_HEADER, markSharedCachePolicy, resolveRevalidateTtl, - resolvePathTtl, resolvePageTtl, matchesLiteralPage, isDottedPathIsrEligible, diff --git a/platform/packages/dispatch/src/isr.ts b/platform/packages/dispatch/src/isr.ts index ce6552b53..4223e82d8 100644 --- a/platform/packages/dispatch/src/isr.ts +++ b/platform/packages/dispatch/src/isr.ts @@ -1,16 +1,10 @@ import { isrCacheKey, isrCacheVariantPrefix, isrEdgeCacheUrl } from '@void/isr'; import { decodeIsrCacheEntry, - extractPageDataFromHtml, - isrCacheResponse, - isStale, - normalizePageDataForJsonCache, packIsrValue, resolvePathTtl, - resolveRevalidateTtl, SHARED_CACHE_POLICY_VERSION, serializeHeaders, - shouldBypassIsr, type IsrCacheEntry, type IsrCacheMetadata, } from '@void/isr/core'; diff --git a/platform/packages/dispatch/test/unit/fallback-rules.test.ts b/platform/packages/dispatch/test/unit/fallback-rules.test.ts index 6438c6f0d..7ab139f21 100644 --- a/platform/packages/dispatch/test/unit/fallback-rules.test.ts +++ b/platform/packages/dispatch/test/unit/fallback-rules.test.ts @@ -47,8 +47,6 @@ type WorkerRoutingEntry = { queryAllowlist?: Record>; }; -type RoutingEntry = StaticRoutingEntry | WorkerRoutingEntry; - /** * Build an Env for static-deployment tests. Assets are identified by their path; * the KV store keys off `assets/{projectId}/{path}` → an ArrayBuffer of the body. diff --git a/platform/packages/dispatch/test/unit/index.test.ts b/platform/packages/dispatch/test/unit/index.test.ts index 1c521c6bb..6ea74e2a1 100644 --- a/platform/packages/dispatch/test/unit/index.test.ts +++ b/platform/packages/dispatch/test/unit/index.test.ts @@ -797,7 +797,7 @@ describe('ISR (stale-while-revalidate)', () => { // → 0 (per-path opt-out, rendered live, never cached). This proves the // pathRevalidate field is threaded through the ISR ladder end-to-end — the // per-path fidelity that build-time baking (one TTL per page) cannot give. - const { env, workerFetch, kvStore } = createEnv({ + const { env, kvStore } = createEnv({ routing: { workerName: 'user-app', projectId: 'proj_1', diff --git a/platform/packages/email-gateway/src/router.ts b/platform/packages/email-gateway/src/router.ts index 72705a812..410b962f2 100644 --- a/platform/packages/email-gateway/src/router.ts +++ b/platform/packages/email-gateway/src/router.ts @@ -422,7 +422,6 @@ export async function routeRelayed( ) { return { reject: true }; } - const slug = authoritative.slug; const workerName = authoritative.workerName; // Built before dispatch so the dispatch-failure paths can log the diff --git a/platform/packages/email-gateway/test/unit/router.test.ts b/platform/packages/email-gateway/test/unit/router.test.ts index 86c01ade6..384d86da1 100644 --- a/platform/packages/email-gateway/test/unit/router.test.ts +++ b/platform/packages/email-gateway/test/unit/router.test.ts @@ -18,12 +18,7 @@ vi.mock('../../src/tenant-dispatch.ts', () => ({ }, })); import type { Env } from '../../../proxy/src/types.ts'; -import { - MAX_INBOUND_BYTES, - MAX_INBOUND_HEADERS, - routeInbound as routeInboundWithRoute, - routeRelayed, -} from '../../src/router.ts'; +import { routeInbound as routeInboundWithRoute, routeRelayed } from '../../src/router.ts'; const ROUTE_FENCE = { routeId: 'route-1', diff --git a/platform/packages/proxy/src/email.ts b/platform/packages/proxy/src/email.ts index 06841e501..878ae41ab 100644 --- a/platform/packages/proxy/src/email.ts +++ b/platform/packages/proxy/src/email.ts @@ -12,7 +12,6 @@ import { import { leaseBearer, leaseEmailDomainCredential } from './email-lease.ts'; import { EMAIL_PROVIDER_DEADLINE_MS, - EmailProviderTimeoutError, createEmailProviderDeadline, type EmailProviderDeadline, } from './email-provider-deadline.ts'; diff --git a/platform/packages/proxy/src/index.ts b/platform/packages/proxy/src/index.ts index 1fb12006b..ebb4da731 100644 --- a/platform/packages/proxy/src/index.ts +++ b/platform/packages/proxy/src/index.ts @@ -17,7 +17,7 @@ import { r2 } from './r2.ts'; import { readRequestJson, requestBodyMaxBytes, RequestBodyError } from './request-body.ts'; import { verifyPrerenderAuthority, verifyProjectDeployAccess } from './resolve.ts'; import { revalidate } from './revalidate.ts'; -import type { Env, JwtPayload, ProxyBody, ProxyEnv } from './types.ts'; +import type { JwtPayload, ProxyBody, ProxyEnv } from './types.ts'; const app = new Hono(); diff --git a/platform/packages/proxy/test/unit/email.test.ts b/platform/packages/proxy/test/unit/email.test.ts index 118861e31..fed8f8482 100644 --- a/platform/packages/proxy/test/unit/email.test.ts +++ b/platform/packages/proxy/test/unit/email.test.ts @@ -219,50 +219,6 @@ function nonAuthKvReads(kv: MockKv): Array { // The floor cache lives for the whole isolate; start every test cold. beforeEach(clearProxyTokenStateCache); -// --- Inbound helpers --- - -function streamOf(bytes: Uint8Array): ReadableStream { - return new ReadableStream({ - start(controller) { - controller.enqueue(bytes); - controller.close(); - }, - }); -} - -function createInboundMessage(to: string, from = 'sender@example.com') { - const bytes = new TextEncoder().encode('Subject: hi\r\n\r\nhello\r\n'); - return { - from, - to, - rawSize: bytes.byteLength, - raw: streamOf(bytes), - headers: new Headers({ Subject: 'hi' }), - setReject: vi.fn(), - forward: vi.fn(async () => {}), - reply: vi.fn(async () => {}), - }; -} - -function createCtx() { - const pending: Array> = []; - return { - ctx: { waitUntil: (p: Promise) => pending.push(p), passThroughOnException: () => {} }, - settle: () => Promise.allSettled(pending), - }; -} - -type InboundMessage = ReturnType; - -async function routeInboundMessage( - env: Record, - message: InboundMessage, -): Promise { - const { ctx, settle } = createCtx(); - await (worker.email as (m: unknown, e: unknown, c: unknown) => Promise)(message, env, ctx); - await settle(); -} - // --- wrangler.jsonc --- /** @@ -565,10 +521,6 @@ function monthKeyFor(projectId: string): string { return `email-sent:${projectId}:${now.getUTCFullYear()}-${String(now.getUTCMonth() + 1).padStart(2, '0')}`; } -function putsWithPrefix(kv: MockKv, prefix: string): Array> { - return kv.put.mock.calls.filter((call) => String(call[0]).startsWith(prefix)); -} - interface SendResponseBody { ok: boolean; error?: { code: string; message: string }; diff --git a/vite.config.ts b/vite.config.ts index a43b193a5..c94348e0e 100644 --- a/vite.config.ts +++ b/vite.config.ts @@ -158,6 +158,8 @@ export default defineConfig({ '.pnpm-store/**', 'playground-local/**', '.worktrees/**', + // Generated by @nkzw/fate, which can import helpers the client does not use. + 'platform/packages/api/src/admin/fate/client.generated.ts', ], overrides: [ { @@ -284,6 +286,8 @@ export default defineConfig({ '@typescript-eslint/no-duplicate-enum-values': 'error', '@typescript-eslint/no-explicit-any': 'error', '@typescript-eslint/no-extra-non-null-assertion': 'error', + // Type-aware: enforced by `vp run lint:platform`; plain `vp lint` skips it. + '@typescript-eslint/no-floating-promises': 'error', '@typescript-eslint/no-misused-new': 'error', '@typescript-eslint/no-non-null-asserted-optional-chain': 'error', '@typescript-eslint/no-require-imports': 'error', @@ -298,7 +302,6 @@ export default defineConfig({ 'getter-return': 'error', 'import/default': 'error', 'import/namespace': 'error', - 'jest/no-focused-tests': 'error', 'no-array-constructor': 'error', 'no-async-promise-executor': 'error', 'no-case-declarations': 'error', @@ -366,6 +369,9 @@ export default defineConfig({ 'no-unused-expressions': 'error', 'no-unused-labels': 'error', 'no-unused-private-class-members': 'error', + // Also covers packages without TypeScript's `noUnusedLocals` and plain JS scripts. + // An options object drops oxlint's default `^_` ignore pattern, so restate it. + 'no-unused-vars': ['error', { args: 'none', varsIgnorePattern: '^_' }], 'no-useless-backreference': 'error', 'no-useless-catch': 'error', 'no-useless-escape': 'error', @@ -412,6 +418,8 @@ export default defineConfig({ 'valid-typeof': 'error', // Import test APIs from `vite-plus/test`, not `vitest`. 'vite-plus/prefer-vite-plus-imports': 'error', + // Vitest rejects `.only` only in CI; catch it locally and in pre-commit too. + 'vitest/no-focused-tests': 'error', }, options: { typeAware: false,