diff --git a/packages/react/test/integration/react-pages-client.test.ts b/packages/react/test/integration/react-pages-client.test.ts index 87d161596..73c964b7d 100644 --- a/packages/react/test/integration/react-pages-client.test.ts +++ b/packages/react/test/integration/react-pages-client.test.ts @@ -762,6 +762,18 @@ function registerClientTests(getBase: () => string, coverage: 'smoke' | 'full') document.querySelector('h1')?.textContent?.includes('Welcome'), ); expect(await page.title()).toBe('Home | React Pages Demo'); + + await page.click('a[href="/deferred"]'); + await page.waitForFunction(() => + document.querySelector('h1')?.textContent?.includes('Deferred'), + ); + expect(await page.title()).toBe(''); + + await page.goBack(); + await page.waitForFunction(() => + document.querySelector('h1')?.textContent?.includes('Welcome'), + ); + expect(await page.title()).toBe('Home | React Pages Demo'); } finally { await page.context().close(); } diff --git a/packages/void/src/pages/head-client.ts b/packages/void/src/pages/head-client.ts index 39eeecc19..8c0db73de 100644 --- a/packages/void/src/pages/head-client.ts +++ b/packages/void/src/pages/head-client.ts @@ -153,7 +153,5 @@ export function applyClientHead(head: HeadDescriptor | undefined): void { cursor = el.nextSibling as Node | null; } - if (head?.title !== undefined) { - document.title = head.title; - } + document.title = head?.title ?? ''; } diff --git a/packages/void/test/unit/pages-head-client.test.ts b/packages/void/test/unit/pages-head-client.test.ts index faf6f2abf..a671ca3ea 100644 --- a/packages/void/test/unit/pages-head-client.test.ts +++ b/packages/void/test/unit/pages-head-client.test.ts @@ -231,6 +231,24 @@ describe('head-client', () => { expect(children).toEqual([]); }); + it('clears document.title when the next head does not set a title', () => { + stubDocumentHead(); + document.title = 'Previous Title'; + + applyClientHead({ link: [{ rel: 'stylesheet', href: '/a.css' }] }); + + expect(document.title).toBe(''); + }); + + it('clears document.title when the next head is undefined', () => { + stubDocumentHead(); + document.title = 'Previous Title'; + + applyClientHead(undefined); + + expect(document.title).toBe(''); + }); + it('does not preserve tags whose attributes only match through signature delimiters', () => { const staleStylesheet = new HeadElement('link', { 'data-void-head': '',