From fc659d15a9cfdbddb0469f2f4888c61a502300df Mon Sep 17 00:00:00 2001 From: Martin Konstantin Herrmann Date: Wed, 11 Nov 2026 14:39:26 +0100 Subject: [PATCH 1/5] Bump wow-ui-testing to forever 1.60.1.70888 Pins the library with the 70888 client source and inline |T/|A proof icons. Regenerates the spell catalogue (Pounce Bleed ranks now share family 9007), the proof atlas table and the schema snapshot hashes that follow from it. --- .wut-version | 2 +- UnitFrames/Tracking/BuffCatalog.lua | 4 +-- UnitFrames/Tracking/DotCatalog.lua | 8 ++--- data/forever-spells/manifest.json | 50 ++++++++++++++--------------- tests/fixtures/dot_source.json | 4 +-- tests/fixtures/schema_snapshot.txt | 12 +++---- tests/proof/atlases.lua | 2 +- 7 files changed, 41 insertions(+), 41 deletions(-) diff --git a/.wut-version b/.wut-version index 6dcec0e..e6f62a1 100644 --- a/.wut-version +++ b/.wut-version @@ -1 +1 @@ -0997193aeb6d659112724c5f7306f4d7f7f8fae4 # v0.1.0 +2d14d474f929e04f2451ca50d8f2b3c50060a1dd # wow-ui-testing#5 (v0.1.5 once tagged) diff --git a/UnitFrames/Tracking/BuffCatalog.lua b/UnitFrames/Tracking/BuffCatalog.lua index c073f72..810bc63 100644 --- a/UnitFrames/Tracking/BuffCatalog.lua +++ b/UnitFrames/Tracking/BuffCatalog.lua @@ -1,9 +1,9 @@ local _, ns = ... ns.BuffCatalog = { - build = "1.60.1.70862", + build = "1.60.1.70888", interface = 16001, - uiCommit = "9dc84f0d3bbae1768ac3405b3716000bd93eda06", + uiCommit = "4cd0ab752a77164f654ccbca9d0c1fe8dafceebe", families = { [17] = { name = "Power Word: Shield", class = "PRIEST", kind = "absorb", ids = { 17, 592, 600, 3747, 6065, 6066, 10898, 10899, 10900, 10901, 27607, 27779, 1236154 } }, [139] = { name = "Renew", class = "PRIEST", kind = "hot", ids = { 139, 6074, 6075, 6076, 6077, 6078, 10927, 10928, 10929, 25315, 27606, 425268, 425269, 425270, 425271, 425272, 425273, 425274, 425275, 425276, 425277, 1236151 } }, diff --git a/UnitFrames/Tracking/DotCatalog.lua b/UnitFrames/Tracking/DotCatalog.lua index a428ca8..d5c7e45 100644 --- a/UnitFrames/Tracking/DotCatalog.lua +++ b/UnitFrames/Tracking/DotCatalog.lua @@ -1,9 +1,9 @@ local _, ns = ... ns.DotCatalog = { - build = "1.60.1.70862", + build = "1.60.1.70888", interface = 16001, - uiCommit = "9dc84f0d3bbae1768ac3405b3716000bd93eda06", + uiCommit = "4cd0ab752a77164f654ccbca9d0c1fe8dafceebe", spells = { [133] = { family = 133, school = 4, classMask = 128, durationMs = 4000, maxDurationMs = 4000, durationPerResourceMs = 0, periodMs = 2000, aura = 3, basePoints = 1, pointsPerResource = 0, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 18, projectile = true, supercedes = { } }, [143] = { family = 133, school = 4, classMask = 128, durationMs = 6000, maxDurationMs = 6000, durationPerResourceMs = 0, periodMs = 2000, aura = 3, basePoints = 1, pointsPerResource = 0, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 32, projectile = true, supercedes = { } }, @@ -67,8 +67,8 @@ ns.DotCatalog = { [9492] = { family = 1079, school = 1, classMask = 1024, durationMs = 12000, maxDurationMs = 12000, durationPerResourceMs = 0, periodMs = 2000, aura = 3, basePoints = 5, pointsPerResource = 9, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 0, projectile = false, supercedes = { 1079 } }, [9493] = { family = 1079, school = 1, classMask = 1024, durationMs = 12000, maxDurationMs = 12000, durationPerResourceMs = 0, periodMs = 2000, aura = 3, basePoints = 8, pointsPerResource = 10.5, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 0, projectile = false, supercedes = { 9492 } }, [9752] = { family = 1079, school = 1, classMask = 1024, durationMs = 12000, maxDurationMs = 12000, durationPerResourceMs = 0, periodMs = 2000, aura = 3, basePoints = 10, pointsPerResource = 15.8000001907, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 0, projectile = false, supercedes = { 9493 } }, - [9824] = { family = 9824, school = 1, classMask = 1024, durationMs = 18000, maxDurationMs = 18000, durationPerResourceMs = 0, periodMs = 3000, aura = 3, basePoints = 25, pointsPerResource = 0, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 0, projectile = false, supercedes = { 9007 } }, - [9826] = { family = 9826, school = 1, classMask = 1024, durationMs = 18000, maxDurationMs = 18000, durationPerResourceMs = 0, periodMs = 3000, aura = 3, basePoints = 31, pointsPerResource = 0, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 0, projectile = false, supercedes = { 9824 } }, + [9824] = { family = 9007, school = 1, classMask = 1024, durationMs = 18000, maxDurationMs = 18000, durationPerResourceMs = 0, periodMs = 3000, aura = 3, basePoints = 25, pointsPerResource = 0, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 0, projectile = false, supercedes = { 9007 } }, + [9826] = { family = 9007, school = 1, classMask = 1024, durationMs = 18000, maxDurationMs = 18000, durationPerResourceMs = 0, periodMs = 3000, aura = 3, basePoints = 31, pointsPerResource = 0, spellPowerCoefficient = 0, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 0, projectile = false, supercedes = { 9824 } }, [9833] = { family = 8921, school = 64, classMask = 1024, durationMs = 12000, maxDurationMs = 12000, durationPerResourceMs = 0, periodMs = 3000, aura = 3, basePoints = 39, pointsPerResource = 0, spellPowerCoefficient = 0.12999999523, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 91, projectile = false, supercedes = { } }, [9834] = { family = 8921, school = 64, classMask = 1024, durationMs = 12000, maxDurationMs = 12000, durationPerResourceMs = 0, periodMs = 3000, aura = 3, basePoints = 49, pointsPerResource = 0, spellPowerCoefficient = 0.12999999523, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 111, projectile = false, supercedes = { } }, [9835] = { family = 8921, school = 64, classMask = 1024, durationMs = 12000, maxDurationMs = 12000, durationPerResourceMs = 0, periodMs = 3000, aura = 3, basePoints = 60, pointsPerResource = 0, spellPowerCoefficient = 0.12999999523, attackPowerCoefficient = 0, pointsPerLevel = 0, directPoints = 135, projectile = false, supercedes = { } }, diff --git a/data/forever-spells/manifest.json b/data/forever-spells/manifest.json index 6f992cc..5a6d986 100644 --- a/data/forever-spells/manifest.json +++ b/data/forever-spells/manifest.json @@ -1,62 +1,62 @@ { - "build": "1.60.1.70862", + "build": "1.60.1.70888", "format": 1, "interface": 16001, "tables": { "SkillLineAbility": { - "filename": "SkillLineAbility.1.60.1.70862.csv", + "filename": "SkillLineAbility.1.60.1.70888.csv", "rows": 7853, "sha256": "13ef58a08253125e3e9dca642a39bc480187987e90cfbe5c8be30e1ab3c8be0a", - "url": "https://wago.tools/db2/SkillLineAbility/csv?build=1.60.1.70862&locale=enUS" + "url": "https://wago.tools/db2/SkillLineAbility/csv?build=1.60.1.70888&locale=enUS" }, "SpellAuraVisibility": { - "filename": "SpellAuraVisibility.1.60.1.70862.csv", + "filename": "SpellAuraVisibility.1.60.1.70888.csv", "rows": 186, "sha256": "5f29e07ad621fd137fc86ccc673eb065a6e0d1cc2e074db96e65556b198edaf9", - "url": "https://wago.tools/db2/SpellAuraVisibility/csv?build=1.60.1.70862&locale=enUS" + "url": "https://wago.tools/db2/SpellAuraVisibility/csv?build=1.60.1.70888&locale=enUS" }, "SpellClassOptions": { - "filename": "SpellClassOptions.1.60.1.70862.csv", - "rows": 6118, - "sha256": "9f45a7ce5c91e4f773466204276cdc3a129ceccc325ba55d982db5349c30ff7b", - "url": "https://wago.tools/db2/SpellClassOptions/csv?build=1.60.1.70862&locale=enUS" + "filename": "SpellClassOptions.1.60.1.70888.csv", + "rows": 6121, + "sha256": "e91c48005fae22c0904144655623d33662db3b50afede67ae69c1931420b1c92", + "url": "https://wago.tools/db2/SpellClassOptions/csv?build=1.60.1.70888&locale=enUS" }, "SpellDuration": { - "filename": "SpellDuration.1.60.1.70862.csv", + "filename": "SpellDuration.1.60.1.70888.csv", "rows": 134, "sha256": "4787f303fe8487cd67e5f9e8574fdc6fa2a03516dcfaabba23d9944f937223f5", - "url": "https://wago.tools/db2/SpellDuration/csv?build=1.60.1.70862&locale=enUS" + "url": "https://wago.tools/db2/SpellDuration/csv?build=1.60.1.70888&locale=enUS" }, "SpellEffect": { - "filename": "SpellEffect.1.60.1.70862.csv", - "rows": 43506, - "sha256": "cc8f167fe246b495294b560196f6c59439f703e8f937ddb6acd81157bd5f8b9c", - "url": "https://wago.tools/db2/SpellEffect/csv?build=1.60.1.70862&locale=enUS" + "filename": "SpellEffect.1.60.1.70888.csv", + "rows": 43508, + "sha256": "da2fb074eedb51bd1246ef53666044c0b757bdb67340c3969b712caa8481ac2b", + "url": "https://wago.tools/db2/SpellEffect/csv?build=1.60.1.70888&locale=enUS" }, "SpellInterrupts": { - "filename": "SpellInterrupts.1.60.1.70862.csv", + "filename": "SpellInterrupts.1.60.1.70888.csv", "rows": 10029, "sha256": "c02057d76ddd00d739fb461c4ff3020fbbb65855ddca23d300875eb9cdc8e54d", - "url": "https://wago.tools/db2/SpellInterrupts/csv?build=1.60.1.70862&locale=enUS" + "url": "https://wago.tools/db2/SpellInterrupts/csv?build=1.60.1.70888&locale=enUS" }, "SpellMisc": { - "filename": "SpellMisc.1.60.1.70862.csv", + "filename": "SpellMisc.1.60.1.70888.csv", "rows": 32461, - "sha256": "1188fc9a62e24ca11c682cd8ae2ecb2e8eb19f72e7f76fd8bec1ef22e2732192", - "url": "https://wago.tools/db2/SpellMisc/csv?build=1.60.1.70862&locale=enUS" + "sha256": "4b3d573dae575c2051e71d524dc73ac3590c56aa102b69770675c0eb10508f85", + "url": "https://wago.tools/db2/SpellMisc/csv?build=1.60.1.70888&locale=enUS" }, "SpellName": { - "filename": "SpellName.1.60.1.70862.csv", + "filename": "SpellName.1.60.1.70888.csv", "rows": 32482, "sha256": "4358b3d1a2a859284b2f46cf614e6a1f85320be342acc1c4b68b625f30cf47a5", - "url": "https://wago.tools/db2/SpellName/csv?build=1.60.1.70862&locale=enUS" + "url": "https://wago.tools/db2/SpellName/csv?build=1.60.1.70888&locale=enUS" }, "SpellPower": { - "filename": "SpellPower.1.60.1.70862.csv", + "filename": "SpellPower.1.60.1.70888.csv", "rows": 3501, "sha256": "bdbd6ba6b4d5236d23c9348fcb383c2e81bbc724279b22b3e2cbd0a8c5954a65", - "url": "https://wago.tools/db2/SpellPower/csv?build=1.60.1.70862&locale=enUS" + "url": "https://wago.tools/db2/SpellPower/csv?build=1.60.1.70888&locale=enUS" } }, - "uiCommit": "9dc84f0d3bbae1768ac3405b3716000bd93eda06" + "uiCommit": "4cd0ab752a77164f654ccbca9d0c1fe8dafceebe" } diff --git a/tests/fixtures/dot_source.json b/tests/fixtures/dot_source.json index 9e9bd4b..e0ab3d0 100644 --- a/tests/fixtures/dot_source.json +++ b/tests/fixtures/dot_source.json @@ -1,5 +1,5 @@ { - "build": "1.60.1.70862", + "build": "1.60.1.70888", "interface": 16001, "tables": { "SkillLineAbility": [ @@ -2916,5 +2916,5 @@ } ] }, - "uiCommit": "9dc84f0d3bbae1768ac3405b3716000bd93eda06" + "uiCommit": "4cd0ab752a77164f654ccbca9d0c1fe8dafceebe" } diff --git a/tests/fixtures/schema_snapshot.txt b/tests/fixtures/schema_snapshot.txt index 8f5e490..176689f 100644 --- a/tests/fixtures/schema_snapshot.txt +++ b/tests/fixtures/schema_snapshot.txt @@ -28636,7 +28636,7 @@ option slots type="group" label="Fixed friendly buff slots" option slots.slot1 type="group" label="Friendly buff slot 1" defaults={offsetX=0} option slots.slot1.enabled type="toggle" label="Enabled" default=false option slots.slot1.spell type="text" label="Friendly buff spell IDs" default="" tooltip=#9ee82380 -option slots.slot1.family type="select" label="Track a spell" default="" values=#a2c826ce tooltip=#ebd0a18e +option slots.slot1.family type="select" label="Track a spell" default="" values=#30f6742e tooltip=#ebd0a18e option slots.slot1.own type="toggle" label="Only buffs cast by me" default=true option slots.slot1.size type="range" label="Size" default=14 min=10 max=32 step=1 option slots.slot1.anchor type="select" label="Position" default="TOPLEFT" values=#a082508f @@ -28645,7 +28645,7 @@ option slots.slot1.offsetY type="range" label="Offset Y" default=0 min=-100 max= option slots.slot2 type="group" label="Friendly buff slot 2" defaults={offsetX=16} option slots.slot2.enabled type="toggle" label="Enabled" default=false option slots.slot2.spell type="text" label="Friendly buff spell IDs" default="" tooltip=#9ee82380 -option slots.slot2.family type="select" label="Track a spell" default="" values=#a2c826ce tooltip=#ebd0a18e +option slots.slot2.family type="select" label="Track a spell" default="" values=#30f6742e tooltip=#ebd0a18e option slots.slot2.own type="toggle" label="Only buffs cast by me" default=true option slots.slot2.size type="range" label="Size" default=14 min=10 max=32 step=1 option slots.slot2.anchor type="select" label="Position" default="TOPLEFT" values=#a082508f @@ -28654,7 +28654,7 @@ option slots.slot2.offsetY type="range" label="Offset Y" default=0 min=-100 max= option slots.slot3 type="group" label="Friendly buff slot 3" defaults={offsetX=32} option slots.slot3.enabled type="toggle" label="Enabled" default=false option slots.slot3.spell type="text" label="Friendly buff spell IDs" default="" tooltip=#9ee82380 -option slots.slot3.family type="select" label="Track a spell" default="" values=#a2c826ce tooltip=#ebd0a18e +option slots.slot3.family type="select" label="Track a spell" default="" values=#30f6742e tooltip=#ebd0a18e option slots.slot3.own type="toggle" label="Only buffs cast by me" default=true option slots.slot3.size type="range" label="Size" default=14 min=10 max=32 step=1 option slots.slot3.anchor type="select" label="Position" default="TOPLEFT" values=#a082508f @@ -28965,7 +28965,7 @@ option border.padding type="range" label="Content padding" default=2 inherit="au option slot1 type="group" label="Friendly buff slot 1" defaults={offsetX=0} option slot1.enabled type="toggle" label="Enabled" default=false option slot1.spell type="text" label="Friendly buff spell IDs" default="" tooltip=#9ee82380 -option slot1.family type="select" label="Track a spell" default="" values=#a2c826ce tooltip=#ebd0a18e +option slot1.family type="select" label="Track a spell" default="" values=#30f6742e tooltip=#ebd0a18e option slot1.own type="toggle" label="Only buffs cast by me" default=true option slot1.size type="range" label="Size" default=14 min=10 max=32 step=1 option slot1.anchor type="select" label="Position" default="TOPLEFT" values=#a082508f @@ -28974,7 +28974,7 @@ option slot1.offsetY type="range" label="Offset Y" default=0 min=-100 max=100 st option slot2 type="group" label="Friendly buff slot 2" defaults={offsetX=16} option slot2.enabled type="toggle" label="Enabled" default=false option slot2.spell type="text" label="Friendly buff spell IDs" default="" tooltip=#9ee82380 -option slot2.family type="select" label="Track a spell" default="" values=#a2c826ce tooltip=#ebd0a18e +option slot2.family type="select" label="Track a spell" default="" values=#30f6742e tooltip=#ebd0a18e option slot2.own type="toggle" label="Only buffs cast by me" default=true option slot2.size type="range" label="Size" default=14 min=10 max=32 step=1 option slot2.anchor type="select" label="Position" default="TOPLEFT" values=#a082508f @@ -28983,7 +28983,7 @@ option slot2.offsetY type="range" label="Offset Y" default=0 min=-100 max=100 st option slot3 type="group" label="Friendly buff slot 3" defaults={offsetX=32} option slot3.enabled type="toggle" label="Enabled" default=false option slot3.spell type="text" label="Friendly buff spell IDs" default="" tooltip=#9ee82380 -option slot3.family type="select" label="Track a spell" default="" values=#a2c826ce tooltip=#ebd0a18e +option slot3.family type="select" label="Track a spell" default="" values=#30f6742e tooltip=#ebd0a18e option slot3.own type="toggle" label="Only buffs cast by me" default=true option slot3.size type="range" label="Size" default=14 min=10 max=32 step=1 option slot3.anchor type="select" label="Position" default="TOPLEFT" values=#a082508f diff --git a/tests/proof/atlases.lua b/tests/proof/atlases.lua index d6783b3..49cd9a8 100644 --- a/tests/proof/atlases.lua +++ b/tests/proof/atlases.lua @@ -1,5 +1,5 @@ return { - build = "1.60.1.70862", + build = "1.60.1.70888", atlases = { ["classicon-deathknight"] = { file = 1662186, width = 128, height = 128, left = 0.00048828125, right = 0.06298828125, top = 0.0009765625, bottom = 0.1259765625, tilesH = false, tilesV = false }, ["classicon-demonhunter"] = { file = 1662186, width = 128, height = 128, left = 0.00048828125, right = 0.06298828125, top = 0.1279296875, bottom = 0.2529296875, tilesH = false, tilesV = false }, From 0c10dca012218812b7f76ab113535b083b41a4c4 Mon Sep 17 00:00:00 2001 From: Martin Konstantin Herrmann Date: Wed, 11 Nov 2026 14:39:26 +0100 Subject: [PATCH 2/5] Accept engine Lua builtins in the API contract The library's snapshot lists strsplit, hooksecurefunc, date and friends under lua.builtins (API.EngineLua); count them as client functions, as MagicMap does. --- tests/spec/contract/api_contract_spec.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/contract/api_contract_spec.lua b/tests/spec/contract/api_contract_spec.lua index 16d0f96..1e721f1 100644 --- a/tests/spec/contract/api_contract_spec.lua +++ b/tests/spec/contract/api_contract_spec.lua @@ -23,9 +23,9 @@ local MOCK_ONLY = { ["Mock.TickUnitVisibility"] = "test helper", } --- Documented, defined by Blizzard's Lua, or an engine function Blizzard calls. +-- Documented, defined by Blizzard's Lua, an engine Lua builtin, or an engine function Blizzard calls. local function IsClientFunction(name) - return API.Function(name) or API.LuaGlobal(name) or API.Called(name) + return API.Function(name) or API.LuaGlobal(name) or API.EngineLua(name) or API.Called(name) end describe("Client API contract", function() From d8281afd207d6c24de756f9bb4515d9df33c9a11 Mon Sep 17 00:00:00 2001 From: Martin Konstantin Herrmann Date: Wed, 11 Nov 2026 14:39:26 +0100 Subject: [PATCH 3/5] Keep No Target below the target bar after re-levels A parent level change re-levels every child to parent+1, which put the empty-target frame level with the target bar. Re-assert its level on Apply. --- UnitFrames_ClickGrid/Groups/EmptyTarget.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/UnitFrames_ClickGrid/Groups/EmptyTarget.lua b/UnitFrames_ClickGrid/Groups/EmptyTarget.lua index 13d8d27..cb3fff0 100644 --- a/UnitFrames_ClickGrid/Groups/EmptyTarget.lua +++ b/UnitFrames_ClickGrid/Groups/EmptyTarget.lua @@ -28,6 +28,7 @@ function EmptyTarget:Apply(uf, height, shown) self.presenter:SetHostSize(uf.layout.width, height) self.presenter:Apply(presentation) self.presenter:SetText(cfg.label) + self.frame:SetFrameLevel(self.frame:GetParent():GetFrameLevel()) self.frame:SetShown(shown) end From 2548190bd66122012d411a8f87244325b04d55a3 Mon Sep 17 00:00:00 2001 From: Martin Konstantin Herrmann Date: Wed, 11 Nov 2026 14:39:26 +0100 Subject: [PATCH 4/5] Leave the standalone castbar out of the snapping cases With real layout in the mock it became a visible snap candidate, so the candidate count and the chosen snap depended on pairs order. --- tests/spec/editmode/editmode_snapping_spec.lua | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/editmode/editmode_snapping_spec.lua b/tests/spec/editmode/editmode_snapping_spec.lua index 7cf76cc..13f8a2b 100644 --- a/tests/spec/editmode/editmode_snapping_spec.lua +++ b/tests/spec/editmode/editmode_snapping_spec.lua @@ -48,6 +48,8 @@ describe("Edit Mode snapping", function() for _, unit in ipairs(ns.Units.order) do if unit ~= "player" then ns.Units.frames[unit]:Hide() end end + -- The standalone castbar is a real candidate in Edit Mode; these cases place their own. + ns.EditMode.frames.timers = nil end) after_each(function() From 13c8e4e568072a5e468542ada61fd23061b45454 Mon Sep 17 00:00:00 2001 From: Martin Konstantin Herrmann Date: Wed, 11 Nov 2026 14:44:05 +0100 Subject: [PATCH 5/5] Pin wow-ui-testing v0.1.5 --- .wut-version | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.wut-version b/.wut-version index e6f62a1..6afc1d3 100644 --- a/.wut-version +++ b/.wut-version @@ -1 +1 @@ -2d14d474f929e04f2451ca50d8f2b3c50060a1dd # wow-ui-testing#5 (v0.1.5 once tagged) +a3e77ba7e2373584063192d8b102ae251fc81248 # v0.1.5