[#1004] Make LLM chat base URL allowlist configurable via application properties#1177
Closed
rnetuka wants to merge 1 commit into
Closed
[#1004] Make LLM chat base URL allowlist configurable via application properties#1177rnetuka wants to merge 1 commit into
rnetuka wants to merge 1 commit into
Conversation
…plication properties
Reviewer's GuideMakes the LLM chat base URL allowlist configurable via application properties instead of hardcoded in the resource class, wiring it through WanakuRouterConfig and documenting the new property. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider normalizing and trimming entries from
wanaku.router.llm.allowlist(e.g., spaces, trailing slashes) before using them inLlmChatResourceto avoid subtle mismatches between configured values and incomingbaseUrls. getBaseUrls()returns the underlying configuration list directly; if this list is mutable, you may want to return an unmodifiable copy to avoid accidental modification of config state from callers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider normalizing and trimming entries from `wanaku.router.llm.allowlist` (e.g., spaces, trailing slashes) before using them in `LlmChatResource` to avoid subtle mismatches between configured values and incoming `baseUrl`s.
- `getBaseUrls()` returns the underlying configuration list directly; if this list is mutable, you may want to return an unmodifiable copy to avoid accidental modification of config state from callers.
## Individual Comments
### Comment 1
<location path="docs/configurations.md" line_range="184-186" />
<code_context>
+
+| Property | Description |
+|-------------------------------|----------------------------------------------------------|
+| `wanaku.router.llm.allowlist` | A comma separated list of LLM API URLs that are allowed. |
+
### gRPC Transport
</code_context>
<issue_to_address>
**nitpick (typo):** Consider hyphenating "comma-separated" as a compound adjective.
Because it’s used as a compound adjective before “list,” this should read “comma-separated list of LLM API URLs that are allowed.”
```suggestion
| Property | Description |
|-------------------------------|-----------------------------------------------------------|
| `wanaku.router.llm.allowlist` | A comma-separated list of LLM API URLs that are allowed. |
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+184
to
+186
| | Property | Description | | ||
| |-------------------------------|----------------------------------------------------------| | ||
| | `wanaku.router.llm.allowlist` | A comma separated list of LLM API URLs that are allowed. | |
There was a problem hiding this comment.
nitpick (typo): Consider hyphenating "comma-separated" as a compound adjective.
Because it’s used as a compound adjective before “list,” this should read “comma-separated list of LLM API URLs that are allowed.”
Suggested change
| | Property | Description | | |
| |-------------------------------|----------------------------------------------------------| | |
| | `wanaku.router.llm.allowlist` | A comma separated list of LLM API URLs that are allowed. | | |
| | Property | Description | | |
| |-------------------------------|-----------------------------------------------------------| | |
| | `wanaku.router.llm.allowlist` | A comma-separated list of LLM API URLs that are allowed. | |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1004
Summary by Sourcery
Make the LLM chat base URL allowlist configurable via application properties instead of being hardcoded.
New Features:
Enhancements:
Documentation: