Skip to content

Commit 2f701b3

Browse files
committed
[TASK] Ensure some spacing below translation mode icons
The translation model used in the PageLayoutModule get the available translation modes over an AJAX request and rendering the mode rows in JavaScript. To prepare the reduction of the mode description in `EXT:deepltranslate_core` this change now adds ```html style="margin-bottom: 20px;" ``` to the left mode select column for each mode to ensure some spacing if the description text is to small. Used command(s): ```shell Build/Scripts/runTests.sh -t 12 \ -s buildCoreOverrideJavaScriptFiles \ && Build/Scripts/runTests.sh -t 13 \ -s buildCoreOverrideJavaScriptFiles ``` [1] web-vision/deepltranslate-core#512
1 parent 7971205 commit 2f701b3

5 files changed

Lines changed: 5 additions & 4 deletions

File tree

Build/Overrides/Core12/Sources/TypeScript/backend/localization.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ class Localization {
367367
const iconMarkup: string = await Icons.getIcon(provider.icon, Icons.sizes.large, null, null, MarkupIdentifiers.inline);
368368
return Promise.resolve(
369369
'<div class="row">'
370-
+ '<div class="col-sm-3">'
370+
+ '<div class="col-sm-3" style="margin-bottom: 20px;">'
371371
+ '<label class="btn btn-default d-block t3js-localization-option" data-helptext=".t3js-helptext-translate">'
372372
+ iconMarkup
373373
+ '<input type="radio" name="mode" id="' + provider.identifier + '" value="' + provider.identifier + '" style="display: none">'

Build/Overrides/Core13/Sources/TypeScript/backend/localization/provider-list.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class LocalizationProviders extends LitElement {
2323
public override render(): TemplateResult {
2424
return html`${this.providers.map((provider) =>
2525
html`<div class="row">
26-
<div class="col-sm-3">
26+
<div class="col-sm-3" style="margin-bottom: 20px;">
2727
<input class="btn-check t3js-localization-option" type="radio" name="mode" id="${provider.identifier}" value=${provider.identifier}>
2828
<label class="btn btn-default btn-block-vertical" for="${provider.identifier}" data-action="${provider.identifier}">
2929
<typo3-backend-icon identifier=${provider.icon} size="large"></typo3-backend-icon>

Build/Scripts/runTests.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ prepareCoreOverrideJavaScriptFilesBuildPath() {
3838
fi
3939
git reset --hard
4040
git clean -xdf
41+
git status
4142
git fetch --all --tags --prune
4243
git checkout main
4344
git reset --hard origin/main

Resources/Public/JavaScript/Core12/localization.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Resources/Public/JavaScript/Core13/localization/provider-list.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* The TYPO3 project - inspiring people to share!
1212
*/
1313
var __decorate=function(e,t,i,o){var r,l=arguments.length,a=l<3?t:null===o?o=Object.getOwnPropertyDescriptor(t,i):o;if("object"==typeof Reflect&&"function"==typeof Reflect.decorate)a=Reflect.decorate(e,t,i,o);else for(var n=e.length-1;n>=0;n--)(r=e[n])&&(a=(l<3?r(a):l>3?r(t,i,a):r(t,i))||a);return l>3&&a&&Object.defineProperty(t,i,a),a};import{customElement,property}from"lit/decorators.js";import{html,LitElement}from"lit";import{unsafeHTML}from"lit/directives/unsafe-html.js";let LocalizationProviders=class extends LitElement{render(){return html`${this.providers.map((e=>html`<div class="row">
14-
<div class="col-sm-3">
14+
<div class="col-sm-3" style="margin-bottom: 20px;">
1515
<input class="btn-check t3js-localization-option" type="radio" name="mode" id="${e.identifier}" value=${e.identifier}>
1616
<label class="btn btn-default btn-block-vertical" for="${e.identifier}" data-action="${e.identifier}">
1717
<typo3-backend-icon identifier=${e.icon} size="large"></typo3-backend-icon>

0 commit comments

Comments
 (0)