DeepL support, PHP8.4 support.#12
Open
adiwidjaja wants to merge 14 commits into
Open
Conversation
Add DeepL support
wernerkrauss
reviewed
Jan 7, 2026
Owner
wernerkrauss
left a comment
wernerkrauss
left a comment
There was a problem hiding this comment.
Hi @adiwidjaja, thanks for the PR. some things are unclear to me and updates to tests and README is missing.
| # Available Backends are: | ||
| # class: Netwerkstatt\FluentExIm\Translator\ChatGPTTranslator | ||
|
|
||
| class: Netwerkstatt\FluentExIm\Translator\DeepLTranslator No newline at end of file |
Owner
There was a problem hiding this comment.
this makes Deepl the default. do we really want this for the module?
| public function __construct(string $apiKey = null) | ||
| { | ||
| if($apiKey == null) { | ||
| $apiKey = $this->getAPIKey("CHATGPT_API_KEY"); |
Owner
There was a problem hiding this comment.
this would be a good usage for a constant, wouldn't it?
| public function __construct(string $apiKey = null) | ||
| { | ||
| if($apiKey == null) { | ||
| $apiKey = $this->getAPIKey("DEEPL_API_KEY"); |
Owner
There was a problem hiding this comment.
see above. A constant like CLASS::API_KEY would be cleaner; this could als be used in the Trait, so no need to pass the constant as a string.
fixes an issue, when frontend has different locale than backend
Translate button: pass cms locale as HTTP param
fix writes to live in Backend, which ignores "do publish" checkbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.