Skip to content

Support for Service annotations in WireMock Helm chart #71

@assiakhateeb

Description

@assiakhateeb

Proposal

The WireMock Helm chart currently does not support adding annotations to the Kubernetes Service.

It would be useful to allow configuring service annotations via values.yaml, for example:

service:
  annotations:
    alb.ingress.kubernetes.io/healthcheck-path: /__admin/health

Current Service template yaml:

apiVersion: v1
kind: Service
metadata:
  name: {{ include "wiremock.fullname" . }}
  labels:
    {{- include "wiremock.labels" . | nindent 4 }}
spec:
  type: {{ .Values.service.type }}
  ports:
    - port: {{ .Values.service.externalPort }}
      targetPort: {{ .Values.service.internalPort }}
      protocol: TCP
      {{- if (and (eq .Values.service.type "NodePort") (not (empty .Values.service.nodePort))) }}
      nodePort: {{ .Values.service.nodePort }}
      {{- end }}
      name: {{ include "wiremock.fullname" . }}
  selector:
    {{- include "wiremock.selectorLabels" . | nindent 4 }}

As you can see it doesn't have annotations.

References

https://github.com/wiremock/helm-charts/blob/master/charts/wiremock/templates/service.yaml

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions