Skip to content

BuiltInScorerTypes count test hard-codes magic number 7 #36

@wollax

Description

@wollax

Problem

BuiltInScorerTypes_DerivedFromEnum_HasExpectedCount hard-codes 7. If a new enum member is added, the test fails for the wrong reason — reads as a regression rather than a reminder to update.

Solution

Either derive the count from Enum.GetValues<ScorerType>().Length with an explanatory comment, or replace with a set-equality check against the full expected set.


Created via Kata /kata-add-issue — Phase 14 PR review suggestion

Metadata

Metadata

Assignees

No one assigned

    Labels

    backlogKata backlog issues

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions