Skip to content

Clean up conformance vector comment quality #45

@wollax

Description

@wollax

Problem

PR review of Phase 15 identified comment quality issues across 5 conformance vector files. All issues also exist in the Rust crate's vendored copies (byte-exact parity constraint), so they must be fixed in both locations simultaneously.

Critical:

  • knapsack-basic.toml lines 6-28: Abandoned first scenario (items expensive/cheap-a/cheap-b) remains in comments but those items don't exist in the test data. The redesign rationale also contains an incorrect greedy comparison.

Important:

  • composite-weighted.toml lines 24-27: Scratchpad text # Wait — let me recompute priority is conversational debris.
  • pinned-items.toml lines 22-24: Greedy fill trace omits explicit density-sort step.
  • pinned-items.toml line 27: new(score=1.0) in merged list doesn't clarify score source.
  • u-shaped-basic.toml and u-shaped-equal-scores.toml: right[N]/left[N] notation ambiguous.

Solution

Fix during Phase 17 (Crate Migration) when the Rust crate starts vendoring from the spec tree.


Created via Kata /kata-add-issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    backlogKata backlog issues

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions