out_android_callback skips src location

[alicefrary]

out_android_callback ends with the line

__android_log_print(android_lvl(msg->lvl), tag, "%s", msg->msg_b);

When logging src locations, the buffer and relevant pointers in msg look something like this:

tag_b          msg_b
  |              |
  [TAG] [SRCLOC] [MESSAGE]
      |
    tag_e

tag is just the char* from tag_b to tag_e, so the src location doesn't get passed to __android_log_print.

---

A potential fix might be to add a char *src_b field to the zf_log_message struct, and have the callback use

__android_log_print(android_lvl(msg->lvl), tag, "%s", msg->src_b);

[wonder-mice]

That's unfortunate. Let me think about other options, though your suggestion looks reasonable.

[Mr-Goldberg]

I am currently use this workaround:

 * Buffer layout:
 *
 * tag_b          msg_b
 * |              |
 * [TAG] [SRCLOC] [MESSAGE]
 *     | |
 * tag_e srcLocationAndMessage
 */
static void out_android_callback(const zf_log_message *const msg, void *arg)
{
	VAR_UNUSED(arg);
	*msg->p = 0;
	const char *tag = msg->p;
	const char *srcLocationAndMessage = msg->tag_e;
	if (msg->tag_e != msg->tag_b)
	{
		tag = msg->tag_b;
		*msg->tag_e = 0;

		// Skip separator

		if (srcLocationAndMessage != msg->e)
		{
			srcLocationAndMessage += 1;
		}
	}

	__android_log_print(android_lvl(msg->lvl), tag, "%s", srcLocationAndMessage);
}

However, don't know yet if any potential error can arise.