You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once the worker proxy propagates on the context chain (#230), the Task.proxy and Task.proxy_id wire fields exist only as a deprecated compatibility path for dispatch across mixed minor versions. Remove them at the v1 boundary.
Drop proxy and proxy_id from the Task message in wire.proto and reserve field numbers 5 and 6 so they are never reused.
Stop populating them in Task.to_protobuf; stop reading them in Task.from_protobuf.
Remove the worker-side fallback — the proxy is materialized only from the chain-borne __proxy__.
Remove or migrate the tests that exercise the legacy fields.
After this, the proxy reaches a worker through one mechanism: the context chain.
Motivation
The dedicated fields duplicate what the context chain already carries. #230 keeps them only so a client can dispatch to a worker on a different minor version within the same major version. A major-version boundary lapses that guarantee, so the redundancy and the fallback shim can retire, leaving a single propagation path and a smaller Task schema.
Expected Outcome
Task.proxy and Task.proxy_id are gone from wire.proto; field numbers 5 and 6 are reserved.
Task.to_protobuf and Task.from_protobuf no longer read or write either field.
The worker materializes the proxy only from the chain-borne __proxy__; the fallback read is gone.
The new-client dual-write path is removed.
Tests that covered the legacy fields are removed or migrated to the chain path.
Description
Once the worker proxy propagates on the context chain (#230), the
Task.proxyandTask.proxy_idwire fields exist only as a deprecated compatibility path for dispatch across mixed minor versions. Remove them at the v1 boundary.proxyandproxy_idfrom theTaskmessage inwire.protoand reserve field numbers5and6so they are never reused.Task.to_protobuf; stop reading them inTask.from_protobuf.__proxy__.wool.ContextVar#230 introduced one.After this, the proxy reaches a worker through one mechanism: the context chain.
Motivation
The dedicated fields duplicate what the context chain already carries. #230 keeps them only so a client can dispatch to a worker on a different minor version within the same major version. A major-version boundary lapses that guarantee, so the redundancy and the fallback shim can retire, leaving a single propagation path and a smaller
Taskschema.Expected Outcome
Task.proxyandTask.proxy_idare gone fromwire.proto; field numbers5and6are reserved.Task.to_protobufandTask.from_protobufno longer read or write either field.__proxy__; the fallback read is gone.