Merge pull request #21 from workivate/parent-disabled-exception

Add create method in ParentDisabledException

Author: jakubgiminski

composer.json

@@ -2,7 +2,7 @@
     "name": "workivate/feature-keys",
     "license": "MIT",
     "description": "Feature Keys Domain Framework",
-    "version": "1.0.20",
+    "version": "1.0.21",
     "require": {
         "php": "^7.1"
     },

src/FeatureAccess/FeatureAccessContainer.php

@@ -20,7 +20,7 @@ public function validate(): void
         foreach ($this->accesses as $access) {
             $parent = $access->getParent();
             if ($parent !== null && $access->isEnabled() && $parent->isDisabled()) {
-                throw ParentDisabledException::parentDisabled($access::getName(), $parent::getName());
+                throw ParentDisabledException::create($access::getName(), $parent::getName());
             }
         }
     }

src/FeatureAccess/FeatureAccessContainerException.php

@@ -5,11 +5,6 @@
 
 class FeatureAccessContainerException extends \RuntimeException
 {
-    public static function parentDisabled(string $accessName, string $parentAccessName): self
-    {
-        return new self("Access $accessName cannot be enabled if $parentAccessName is disabled.", 1);
-    }
-
     public static function accessAlreadySet(string $accessName): self
     {
         return new self("Access $accessName is already set. Resetting is forbidden.", 2);

src/FeatureAccess/ParentDisabledException.php

@@ -11,11 +11,16 @@ class ParentDisabledException extends FeatureAccessContainerException
 
     public function __construct(string $accessName, string $parentAccessName)
     {
-        parent::__construct();
+        parent::__construct("Access $accessName cannot be enabled if $parentAccessName is disabled.");
         $this->accessName = $accessName;
         $this->parentAccessName = $parentAccessName;
     }
 
+    public static function create(string $accessName, string $parentAccessName): self
+    {
+        return new self($accessName, $parentAccessName);
+    }
+
     public function getAccessName(): string
     {
         return $this->accessName;

tests/FeatureAccess/FeatureAccessContainerTest.php

@@ -5,6 +5,7 @@
 
 use FeatureKeys\FeatureAccess\FeatureAccessContainer;
 use FeatureKeys\FeatureAccess\FeatureAccessContainerException;
+use FeatureKeys\FeatureAccess\ParentDisabledException;
 use FeatureKeys\Tests\StarWars\FeatureAccess\Accesses\Jedi\JediAccess;
 use FeatureKeys\Tests\StarWars\FeatureAccess\Accesses\Jedi\ObiWanAccess;
 use FeatureKeys\Tests\StarWars\FeatureAccess\Accesses\Jedi\QuiGonAccess;
@@ -70,7 +71,7 @@ public function testCanValidateItself(): void
             $plagueisAccess,
         ];
 
-        $expectedException = FeatureAccessContainerException::parentDisabled(
+        $expectedException = ParentDisabledException::create(
             $plagueisAccess::getName(),
             $sithAccess::getName()
         );