Skip to content

Seven declared statEffects keys in economy.json are never read by any code #76

Description

@wpinrui

economy.json declares stat effects that no code ever reads. Editing them does nothing.

Never read by any code

  • charisma.adResponseBonusPerPoint
  • mechanical.repairQualityBonusPerPoint
  • mechanical.partFindBonusPerPoint
  • mechanical.valueSpotAccuracyPerPoint
  • fitness.laborOutputBonusPerPoint
  • knowledge.researchAccuracyPerPoint
  • knowledge.hiddenListingChancePerPoint
  • All driving keys except carWearReductionPerPoint: roadTripRiskReductionPerPoint, deliveryEfficiencyBonusPerPoint, ticketAvoidancePerPoint, fuelEfficiencyBonusPerPoint

Not all of these are equal

Some are legitimately forward-looking — road trips and deliveries aren't built yet, and it's fine for their config to land early.

But two of them back effects the GDD actively promises to the player today, and they silently don't work:

  • fitness.laborOutputBonusPerPoint — see the Fitness manual-labor bug
  • mechanical.partFindBonusPerPoint — see the hardcoded part-finding bonus

Ask

Triage the list: wire up what's promised, and either delete or clearly comment the rest as forward-looking so the next person balancing the game doesn't waste an afternoon tuning a dead number.


From the 2026-07-13 code audit (Researcher). Verified against main @ b8e0d70.

Metadata

Metadata

Assignees

No one assigned

    Labels

    balanceGame balance and tuningenhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions