Skip to content

Unused variable j #167

@DimitriPapadopoulos

Description

@DimitriPapadopoulos

This feels wrong:

# remove Ellipsis
while Ellipsis in rlist:
i = rlist.index(Ellipsis)
rlist.pop(i)
for j in range(self.ndim - len(rlist)):

  • Variable j is unused.
  • slice(None) is inserted self.ndim - len(rlist) times at the same position i.

Perhaps the intent was:

            for j in range(self.ndim - len(rlist)):
                rlist.insert(i + j, slice(None))

In that case, I would recommend:

   # remove Ellipsis 
    rlist = [x for x in rlist if element != Ellipsis] + [slice(None)] * (self.ndim - len(rlist))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions