Other windows do not follow the switch changes

[RainyNight9]

For example, if I switch the theme between light and dark on the settings page, the window of the settings page will change accordingly, but the theme of my main window will not change. I need to manually reload it for it to take effect. How can I solve this problem?

[wyhaya]

@RainyNight9

The plugin currently has some issues; whenever you switch theme, it only changes the theme of all the windows that have already been created.

For windows created after switching theme, you should call set_theme again to switch it; this plugin will not handle future windows of the App.

Code here:

tauri-plugin-theme/src/platform/macos.rs

Lines 11 to 21 in 6b7d4a2

	for window in app.webview_windows().values() {
	let ptr = window.ns_window().map_err(|_| "Invalid window handle")?;
	unsafe {
	let val = match theme {
	Theme::Auto => nil,
	Theme::Light => NSAppearance(NSAppearanceNameVibrantLight),
	Theme::Dark => NSAppearance(NSAppearanceNameVibrantDark),
	};
	(ptr as id).setAppearance(val);
	}
	}

---

I haven't studied Tauri for a long time, but it seems that Tauri now has a core API to switch theme?

webviewWindow.setTheme("dark");

If that's the case, then this plugin is no longer needed (this plugin is not perfect on Windows).

[RainyNight9]

I have two windows, a main window and a settings window. Both windows are open. I set the theme in the settings operation. The settings change, but the main window does not change. I need to reload it manually.

Well, I saw that the official method has been implemented, but the documentation is not clear, and there are always problems when using it, so I used this plugin when I saw it. I don’t know if it is an official bug or I didn’t understand it.

[RainyNight9]

@wyhaya

Is this plugin still being maintained? If not, I will think of other ways to do it.

[wyhaya]

Try other methods first; The plugin lacks many features.

If the official set_theme doesn't meet your needs, you might consider writing your own theme-plugin. Feel free to copy the code from this plugin; it should work well on Linux and macOS.