Skip to content

Code review 2 by Zisen Zhou #37

Description

@JasonZ82
  1. The structure of the Github is not good enough. There are 5 page3 folders in the master branch. It would be better if you can put all the page3 folders into one folder and use one way to name them.
  2. The code would be more easy to read if some comments are added in the code.
  3. For the useless code you put in the comment for testing, it would be better to just delete them in the Github. For example, the code in master/new_model/model_function.py after line 142.

Overall, the progress of the project is great. The deployment of the website is awesome. So if you still have time, the login&logout system would be great function for you to have a try. Good luck!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions