Looking at NORi's base closure implementation I found out that
https://github.com/xkykai/NORiOceanParameterization.jl/blob/3748016f5e08fb336310fea76a70b96e70a80d6c/NORiImplementation/src/NORiBaseVerticalDiffusivity.jl#L275-277
Is there a specific reason why these lines are here for NORi? It looks like they mimick the RiBasedVerticalDiscretization implementation in Oceananigans where we needed to time-average. But here there is no time average in the computation of the diffusivities. This line will prevent NORi to compute difusivities within the RK stages, possibly leading to instabilities
Looking at NORi's base closure implementation I found out that
https://github.com/xkykai/NORiOceanParameterization.jl/blob/3748016f5e08fb336310fea76a70b96e70a80d6c/NORiImplementation/src/NORiBaseVerticalDiffusivity.jl#L275-277
Is there a specific reason why these lines are here for NORi? It looks like they mimick the RiBasedVerticalDiscretization implementation in Oceananigans where we needed to time-average. But here there is no time average in the computation of the diffusivities. This line will prevent NORi to compute difusivities within the RK stages, possibly leading to instabilities