[GENERAL] OS-STS-SUG-00 | Code Maturity

[xoloki]

Description

1. Mark parties with missing public shares as malicious to strengthen the robustness of the FIRE algorithm. Currently, the function merely returns a failure message (DkgFailure::MissingPublicShares) in dkg_ended, without taking punitive action against the non-compliant participants.
2. To ensure the integrity of the PublicNonce , add validation checks to make sure that D and E are not zero.

>_ wsts/src/common.rs

#[derive(Clone, Debug, Eq, PartialEq, Deserialize, Serialize)] 
#[allow(non_snake_case)]
/// A commitment to the private nonce
pub struct PublicNonce {
    /// A commitment to the private nonce's first value
    pub D: Point,
    /// A commitment to the private nonce's second value 
    pub E: Point,
}

Remediation

Implement the above-mentioned suggestions.