Kan niet commiten bij yard zorgsites

[WybeBosch]

YardZorgsites wilt dat ik php@8.4 heb inpalats van @8.1 imean sure

Maar captain hook wilt dan php 8.3

 $ php8
Unlinking /usr/local/Cellar/php@7.4/7.4.33_8... 25 symlinks removed.
Linking /usr/local/Cellar/php/8.4.2... 24 symlinks created.
Switched to PHP 8.4
PHP 8.4.2 (cli) (built: Dec 17 2024 15:31:31) (NTS)
Copyright (c) The PHP Group
Built by Homebrew
Zend Engine v4.4.2, Copyright (c) Zend Technologies

  ~/Lo/zorgsites/app/public    feat/sc-#526…index-partly +1         4s   10:50:03 
 $ clear
Found existing alias for "clear". You should use: "cls"

  ~/Local Sites/zorgsites/app/public    feat/sc-#526…index-partly +1       10:50:24 
 $ git add --all
Found existing alias for "git add --all". You should use: "gaa"

  ~/Local Sites/zorgsites/app/public    feat/sc-#526…index-partly +1       10:50:26 
 $ git commit -m "(fix): #5265 - disable google index for openingtimes"
Found existing alias for "git". You should use: "g"
pre-commit:
 - ./vendor/bin/php-cs-fixer --config=.php-cs-fixer.php fix {$STA... : failed
captainhook failed executing all actions, took: 0.33s

./vendor/bin/php-cs-fixer --config=.php-cs-fixer.php fix {$STAGED_FILES|of-type:php}
  command output:
PHP CS Fixer 3.76.0 Kids Playground by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 8.4.2
PHP CS Fixer currently supports PHP syntax only up to PHP 8.3, current PHP version: 8.4.2. Add Config::setUnsupportedPhpVersionAllowed(true) to allow executions on unsupported PHP versions. Such execution may be unstable and you may experience code modified in a wrong way.
failed to execute: ./vendor/bin/php-cs-fixer --config=.php-cs-fixer.php fix web/app/themes/sage/resources/views/blocks/practical-info/index.blade.php
failed to execute: ./vendor/bin/php-cs-fixer --config=.php-cs-fixer.php fix web/app/themes/sage/resources/views/blocks/practical-info/index.blade.php

En als ik dan naar 8.3 switch enkel om de commit aan te maken

 $ brew link --force --overwrite php@8.3
Warning: Already linked: /usr/local/Cellar/php@8.3/8.3.15
To relink, run:
  brew unlink php@8.3 && brew link --force php@8.3

  ~/Local Sites/zorgsites/app/public    feat/sc-#526…index-partly +1                                                10:54:22 
 $ export PATH="/usr/local/opt/php@8.3/bin:$PATH"
export PATH="/usr/local/opt/php@8.3/sbin:$PATH"

  ~/Local Sites/zorgsites/app/public    feat/sc-#526…index-partly +1                                                10:54:36 
 $ php -v
PHP 8.3.15 (cli) (built: Dec 17 2024 18:18:02) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.15, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.15, Copyright (c), by Zend Technologies

  ~/Local Sites/zorgsites/app/public    feat/sc-#526…index-partly +1                                                10:54:38 
 $ git commit -m "(fix): #5265 - disable google index for openingtimes"
Found existing alias for "git". You should use: "g"
PHP Fatal error:  Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.4.0". You are running 8.3.15. in /Users/wybe/Local Sites/zorgsites/app/public/vendor/composer/platform_check.php on line 22

Fatal error: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.4.0". You are running 8.3.15. in /Users/wybe/Local Sites/zorgsites/app/public/vendor/composer/platform_check.php on line 22

dan mag het alsnog niet haha

[WybeBosch]

Zelfs met noverify kreeg ik alsnog gezeik over php??? xD

 $ git commit -m "(fix): #5265 - disable google index for openingtimes" --no-verify
Found existing alias for "git". You should use: "g"
PHP Fatal error:  Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.4.0". You are running 8.3.15. in /Users/wybe/Local Sites/zorgsites/app/public/vendor/composer/platform_check.php on line 22

Fatal error: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.4.0". You are running 8.3.15. in /Users/wybe/Local Sites/zorgsites/app/public/vendor/composer/platform_check.php on line 22

En toen ik dus weer switche naar php 8.4
en DAN noverify deed, kwam ik er eindelijk wel langs :P

[mvdhoek1]

8.4 wordt nog niet ondersteund door php-cs-fixer vandaar ook deze toevoeging voor de actions: https://github.com/yardinternet/zorgsites/blob/main/.github/workflows/format-php.yml

In de vendor package kun je de melding uitzetten zodat je wel door kan.
Wat mij betreft verwijder je dit issue en maak je een nieuwe algemene aan voor in de toekomst om dit op te pakken wanneer php-cs-fixer wel 8.4 ondersteund :)