index of arrayOfSquare exceeds 4

[pacozhong]

I find a bug about these lines of code(BaseGenerator.php):

foreach ($chars[1] as $i => $char) {
if ($i % 3 == 0) {
$this->arrayOfSquare[$i/3][0] = $this->convertHexaToBoolean($char);
$this->arrayOfSquare[$i/3][4] = $this->convertHexaToBoolean($char);
} elseif ($i % 3 == 1) {
$this->arrayOfSquare[$i/3][1] = $this->convertHexaToBoolean($char);
$this->arrayOfSquare[$i/3][3] = $this->convertHexaToBoolean($char);
} else {
$this->arrayOfSquare[$i/3][2] = $this->convertHexaToBoolean($char);
}
ksort($this->arrayOfSquare[$i/3]);
}

the length of $char is 16, when $i is 15, $i / 3 is 5, which is not correct, because the size of matrix is 5, the max value of $i must be smaller than 5.

[blaugueux]

If you find a bug please submit a PR with a unit test reproducing the issue and a fix. Thanks for your work.

[blaugueux]

@pacozhong Do you plan to submit a PR or should I close your issue?

[blaugueux]

✅ Resolved in v3.0.0 #82

The entire codebase has been rewritten from scratch. The grid generation logic is now handled by the SymmetricGridGenerator class with proper bounds checking.

The new implementation uses a clean approach that iterates over valid grid positions only:

for ($y = 0; $y < $gridSize->rows; $y++) {
    for ($x = 0; $x < $halfColumns; $x++) {
        // Safe bounds, no overflow possible
    }
}
This bug no longer exists in v3.