Do we have sensible defaults for .serialize(params, encode)?

[matthewdunsdon]

On a couple of projects, team have made use of .serialize(params, encode).

By default, it encodes parameters with the identify function.

Should it not use the encodeURIComponent by default and allow people to opt in if they want to avoid encoding?

I do appreciate that serialize is not documented in the readme.md file.

[matthewdunsdon]

@zambezi/contributors Please jump in and share your thoughts. 😄

[mstade]

Do we have any data to suggest there's a need for a custom encoding function at all? I.e. should we not just always encode?

[matthewdunsdon]

Searching through everyone's code, I can not see anyone who is passing in a custom function.

The only think I am not sure of is whether anyone has had to do their own encodeURIComponent on the input they pass to serialize. That data is really hard to mine with the current tools I have available.

[mstade]

Maybe we can pair up on doing some research? I'd be all for dropping this parameter if we can, and just applying encoding by default, or something else sensible like that.