Skip to content

Follow-ups: deferred test-nits across the Smart Orcastrators epic (#5) #26

Description

@zaridan

Cheap hardening deferred during the epic build (all non-blocking; code verified-correct where flagged). Fold in opportunistically.

#11 picker (PR #25):

  • No OrchestratorLaunchModal.test.tsx — add a modal-level test asserting: flag-off → recipe option not rendered + dispatch goes Smart; flag-on + Recipe + recipe → RecipeDirectorBackend(recipe); Smart → LlmDirectorBackend. (Gate code verified correct; just untested.)
  • The 6 panel nits (i18n locale consistency, styleguide polish) — re-run a scoped review to enumerate.

#15 F4 (renderer run binding):

  • Desktop preload binding test; shared mirror-type compile-time link; registry-constant assertion; taskCreate rejection test.

Recipe layer:

  • Per-task agent override + a per-task taskCreate agent param (re-add when heterogeneous-agent recipes are needed).
  • Hybrid director backend (recipe-until-blocked → scoped LLM) — the third mode from the original pitch, not yet built.

Process note (for our own tooling): the review-panel synthesis agent repeatedly mis-targeted (ran gh pr view without --repo, read the director cwd instead of the PR worktree) — the lens agents were fine. Fix the panel harness to pass --repo + read the worktree, or drop the synthesis step's re-verification.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions