Refactor and Cleanup Gamification

[xXPinkmagicXx]

This issue is for collection TODOs and small issues for gamification

Fixes

• Use username instead of user_id in the frontend and endpoints
• Remove unneeded files (e.g. /pages/Friends.js)
• Order migration files
• Update the period for the leaderboard to be two weeks Change the period on the leaderboards from half a month to two weeks. #987
• Add option to see the previous period on the leaderboard Option to see previous period of the leaderboard #986
• Username is overflowing
• If you update your username to an already existing username the page turn black (should throw error)
• If you updates your email to an already existing email the backend crashes
• Address streak badge progress issue
• Only show the classroom leaderboard if you are in a classroom
• Upgrade the name and email column to utf8mb4_unicode_ci update collation for the name and email column (utf8mb4_unicode_ci) api#541
• Add class room SQL script / write email
• Move the Profile from "..." (more) to top bar on mobile, either right or left. At the same levels Feature/mobile profile icon top #1041
• Update Sign up form
• Update delete logic (user_account_deletion.py) to include gamification entities (friend, friend request, badge etc. )
• Fix validator frontend (Utf8 validator might not be needed after the migration for name and username) Revert "Fix/input validation profile" #1037

Second Review

• raise None raises TypeError instead of returning
• Mixing SQLAlchemy query APIs
• Double password update
• Avatar overwritten with None on every settings save (We might have to discuss this with Mircea, Avatar data is never None, all the values are sent as updated even if none of them were updated -> this matches the logic of the other values of the user_settings)
• UnboundLocalError in error handlers (Gábor) Fixed friend UnboundLocalError issue api#549
• Extra db_session.commit() in four_levels_per_word.py (Gábor) Fixed minor review issues api#550
• friend_streak_changed fires too often (Gábor)
• get_friend_details exposes data to non-friends (Nicklas) Pop the email from details as dictionary api#551
• Remove email from search (Nicklas) Remove email search + escape characters api#546
• LIKE wildcards not escaped in search (Nicklas) Remove email search + escape characters api#546
• Inconsistent indentation in friend_request.py (Nicklas) Fix/friend request indentation api#547
• Dead code: GAMIFICATION_START_DATE (Nicklas) Removed gamification date api#545
• Missing newline at end of file (Gábor) Fixed minor review issues api#550
• Stale copy-paste comments (Nicklas) Fix/friend request indentation api#547
• Test asserts wrong key (Nicklas) Fix test_badges api#548
• Inconsistent enum naming in ActivityTypeMetric (Gábor) Fixed minor review issues api#550

No change needed

• See peoples name when searching new friends? ( this is okay for now)

Documentation

• The different decision about the gamification features ( most are in comments i guess)

Testing

• New features
• That experiment do not have a classroom
• Dark mode
• Mobile
• Web

[xXPinkmagicXx]

username overflowing:

[xXPinkmagicXx]

Maybe, if you do not have any read articles, the leaderboard will not load?

[xXPinkmagicXx]

Consider the layout on mobile for the leaderboard

[xXPinkmagicXx]

Should the "classroom" tab be disabled for the experiment?

[xXPinkmagicXx]

Should you be able to see users full name when you are not friends?

[gabortodor]

Maybe, if you do not have any read articles, the leaderboard will not load?

We should look into this.

Edit: I am not sure what the issue was, I tested all the leaderboards with a brand new profile and all of them loaded with the correct value of 0

[gabortodor]

Should the "classroom" tab be disabled for the experiment?

I don't think so, we can just simply explain to the users that they will be added into a classroom for the experiment.

[gabortodor]

Should you be able to see users full name when you are not friends?

Yeah, I don't really see an issue with this