Skip to content

Commit 9e71cc2

Browse files
authored
Merge pull request #151 from tarcieri/rename-try-from-rng-to-try-random
Rename `Field::try_from_rng` => `try_random`
2 parents bcd2cfa + 9b18f64 commit 9e71cc2

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

ff_derive/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1259,7 +1259,7 @@ fn prime_field_impl(
12591259
const ONE: Self = R;
12601260

12611261
/// Computes a uniformly random element using rejection sampling.
1262-
fn try_from_rng<R: ::ff::derive::rand_core::TryRng + ?Sized>(rng: &mut R) -> ::core::result::Result<Self, R::Error> {
1262+
fn try_random<R: ::ff::derive::rand_core::TryRng + ?Sized>(rng: &mut R) -> ::core::result::Result<Self, R::Error> {
12631263
loop {
12641264
let mut tmp = {
12651265
let mut repr = [0u64; #limbs];

src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,12 @@ pub trait Field:
7676

7777
/// Returns an element chosen uniformly at random using a user-provided RNG.
7878
fn random<R: Rng + ?Sized>(rng: &mut R) -> Self {
79-
let Ok(out) = Self::try_from_rng(rng);
79+
let Ok(out) = Self::try_random(rng);
8080
out
8181
}
8282

8383
/// Returns an element chosen uniformly at random using a user-provided RNG.
84-
fn try_from_rng<R: TryRng + ?Sized>(rng: &mut R) -> Result<Self, R::Error>;
84+
fn try_random<R: TryRng + ?Sized>(rng: &mut R) -> Result<Self, R::Error>;
8585

8686
/// Returns true iff this element is zero.
8787
fn is_zero(&self) -> Choice {

tests/derive.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ mod full_limbs {
3434
use getrandom::{rand_core::UnwrapErr, SysRng};
3535

3636
let _ = F384p::random(&mut UnwrapErr(SysRng));
37-
let _ = F384p::try_from_rng(&mut SysRng).unwrap();
37+
let _ = F384p::try_random(&mut SysRng).unwrap();
3838
}
3939
}
4040

0 commit comments

Comments
 (0)