Skip to content

Documentation in impl PartialEq for $projective seems incorrect #96

@PlasmaPower

Description

@PlasmaPower

A comment in the impl says:

// The points (X, Y, Z) and (X', Y', Z')
// are equal when (X * Z^2) = (X' * Z'^2)
// and (Y * Z^3) = (Y' * Z'^3).

However, the impl seems to actually check this:

                // The points (X, Y, Z) and (X', Y', Z')
                // are equal when (X * Z'^2) = (X' * Z^2)
                // and (Y * Z'^3) = (Y' * Z^3).

I think the comment is wrong and the implementation is correct. Either way, this should be fixed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions