create_script_tag() is malfunctioning

[phillijw]

I'm running into an issue with the following code. You can see that it's inserting an 0x02 and 0x08 where it shouldn't (see the right side of the diff). The left side is the correct output.

custom_payload = FLVObject()
custom_payload["audioBandwidth"] = struct.pack(">d", 64000.0)
custom_payload["audioChannels"] = struct.pack(">d", 1.0)
custom_payload["audioFrequency"] = struct.pack(">d", 48000.0)
custom_payload["channelId"] = struct.pack(">d", 0.0)
payload = create_script_tag('onMetaData', custom_payload, 0)

[phillijw]

flvlib3/flvlib3/tags.py

Line 219 in 5f7ba11

# Here there's always a byte with the value of 0x02,

There is some code which references this 0x02 and I'm wondering if it's kind of a bug or a hack to make youtube work?

[phillijw]

See this issue: wulczer/flvlib#3

You should've forked this repo instead of copy and pasting it. Makes merging really difficult :(