Fix webview lag during canvas panning - #660
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
Electron A/B traces used 1, 2, 5, 10, and 25 live webviews with three 120-frame pan sweeps per count. The previous path missed immediate alignment on 11 of 12 probes at every count; the optimized path missed 0 of 12. Median geometry cost ranged from 0.29 ms/frame with one webview to 2.34 ms/frame with 25 webviews. At 25 webviews, median p95 frame time was 10.1 ms versus 10.5 ms before the fix on a 120 Hz display.
Validation