Skip to content

Conversation

@hemulin
Copy link
Contributor

@hemulin hemulin commented Jun 4, 2025

  • Added Vouching and ancestry graphs to Account overview page
  • General cleaning and improvements
  • Note: Expecting to find CLICKHOUSE_DATABASE="olfyi" in the deployment env vars
    image

@hemulin hemulin requested a review from dboreham June 4, 2025 02:02
@@ -0,0 +1,184 @@
import { FC, useEffect, useState } from 'react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this lock file should be checked in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you refer to.
I used pnpm (which generates the pnpm-lock).
Regardless, lock files should be checked in to ensure that everyone installs exactly the same dependency versions.
There is a package-lock (npm) in the api folder, none in the web-app (which is weird)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock files checked in is a matter of opinion but this project never had the lock file checked in before.

@dboreham
Copy link
Contributor

dboreham commented Jun 6, 2025

I was able to resolve the web app build errors with these changes:

diff --git a/web-app/src/modules/core/routes/Account/Ancestry.tsx b/web-app/src/modules/core/routes/Account/Ancestry.tsx
index d0e0d0b..bda6318 100644
--- a/web-app/src/modules/core/routes/Account/Ancestry.tsx
+++ b/web-app/src/modules/core/routes/Account/Ancestry.tsx
@@ -39,9 +39,6 @@ const Ancestry: FC<Props> = ({ address }) => {
         // Create the full ancestry chain including current account
         const fullAncestryChain = [...ancestryTree, address];

-        // Get base URL for account links
-        const baseUrl = `${window.location.protocol}//${window.location.hostname}${window.location.port ? ':' + window.location.port : ''}`;
-
         // Transform data for ECharts graph visualization
         const nodes = fullAncestryChain.map((addr, index) => ({
           name: `${addr.slice(0, 8)}...`,
diff --git a/web-app/tsconfig.node.json b/web-app/tsconfig.node.json
index 5c81d84..42872c5 100644
--- a/web-app/tsconfig.node.json
+++ b/web-app/tsconfig.node.json
@@ -6,8 +6,5 @@
     "moduleResolution": "bundler",
     "allowSyntheticDefaultImports": true
   },
-  "include": [
-    "vite.config.ts",
-    "src/config.ts"
-  ]
+  "include": ["vite.config.ts"]
 }

@dboreham dboreham merged commit 1c3fcd9 into 0LNetworkCommunity:main Jun 6, 2025
2 checks passed
@dboreham dboreham mentioned this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants