PR23 forest: Ignore missing effect manifests

[0cwa]

Publish fix-effects-null-manifest as one component PR in the corrected PR23 forest.
Topology: parent base at 6f831813c933d79070600c4b0d47f3318340b0d7 (parent_remote_branch: pr23/forest/base). Child tip 42bd9d06e0881c676a8b64ea3882cdf9d7764e76; publish as 0cwa:pr23/forest/fix-effects-null-manifest.
Class small-fix; direct scope (1): src/effects/backends/effectsbackendmanager.cpp.
Commits: 42bd9d06e0881c676a8b64ea3882cdf9d7764e76 — Ignore missing effect manifests.
Source anchors: pr23/fix/effects-null-manifest, 42bd9d06e0881c676a8b64ea3882cdf9d7764e76.
Manifest validation only; CI/GitHub status is not inferred. Known limitations remain as documented in the manifest.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a80bac3a-63c7-4792-87cb-760fe1805eac

📥 Commits

Reviewing files that changed from the base of the PR and between 6f83181 and 42bd9d0.

📒 Files selected for processing (1)

• src/effects/backends/effectsbackendmanager.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

addBackend now skips null manifests returned by getManifest(effectId) before appending manifests to m_manifests.

Changes

Effect backend registration

Layer / File(s)	Summary
Manifest null guard src/effects/backends/effectsbackendmanager.cpp	addBackend stores the manifest in a local variable and appends it only when the value is non-null.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 42bd9

No actionable current-head risk is identified; unavailable effect manifests are safely skipped.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: ignoring missing effect manifests. It is concise and specific.
Description check	✅ Passed	The description directly relates to the changeset. It identifies the affected file, the missing-manifest fix, and the pull request scope.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch pr23/forest/fix-effects-null-manifest

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks each manifest with care
Null ones stop before the list is there
Valid effects hop safely in
The backend keeps its tidy grin
Four paws guard the flow within}

_{Comment @coderabbitai help to get the list of available commands.}

[coveralls]

Coverage Report for CI Build 34773397453

Warning

No base build found for commit 6f83181 on pr23/forest/base.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 30.364%

Details

• Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →

---

Coverage Stats

Relevant Lines:	117473
Covered Lines:	35670
Line Coverage:	30.36%
Coverage Strength:	54297.27 hits per line

---

💛 - Coveralls

[0cwa]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.