Skip to content

PR23 forest: Rebase feature-waveform-zoom onto declared parent - #44

Open
0cwa wants to merge 1 commit into
pr23/forest/basefrom
pr23/forest/feature-waveform-zoom
Open

0cwa wants to merge 1 commit into
pr23/forest/basefrom
pr23/forest/feature-waveform-zoom

Conversation

@0cwa

@0cwa 0cwa commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Publish feature-waveform-zoom as one component PR in the corrected PR23 forest.
Topology: parent base at 6f831813c933d79070600c4b0d47f3318340b0d7 (parent_remote_branch: pr23/forest/base). Child tip 230a94707f71933be4c0ff73fefcdfe6671f4864; publish as 0cwa:pr23/forest/feature-waveform-zoom.
Class large-feature; direct scope (19): res/qml/Settings/Interface.qml, res/qml/Settings/SpinBox.qml, res/qml/WaveformDisplay.qml, src/engine/enginemixer.cpp, src/engine/enginemixer.h, src/mixer/basetrackplayer.cpp, src/mixer/basetrackplayer.h, src/preferences/dialog/dlgprefwaveform.cpp, src/preferences/dialog/dlgprefwaveform.h, src/preferences/dialog/dlgprefwaveformdlg.ui, src/qml/qmlconfigproxy.cpp, src/qml/qmlconfigproxy.h, src/test/dlgprefwaveform_test.cpp, src/test/interfaceqml_test.cpp, src/test/playermanagertest.cpp, src/waveform/renderers/waveformwidgetrenderer.cpp, src/waveform/renderers/waveformwidgetrenderer.h, src/waveform/waveformwidgetfactory.cpp, src/waveform/waveformwidgetfactory.h.
Commits: 230a94707f71933be4c0ff73fefcdfe6671f4864 — Rebase feature-waveform-zoom onto declared parent.
Source anchors: pr23/stack/waveform-zoom, fbc22135c738199e08c47ad04cf78a01654c587a, refs/audit/pr23/feature-waveform-zoom, 230a94707f71933be4c0ff73fefcdfe6671f4864.
Manifest validation only; CI/GitHub status is not inferred. Known limitations remain as documented in the manifest.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6d1c7f05-adc2-4f3a-be13-94b9cb3c72b6

📥 Commits

Reviewing files that changed from the base of the PR and between 6f83181 and 230a947.

📒 Files selected for processing (19)
  • res/qml/Settings/Interface.qml
  • res/qml/Settings/SpinBox.qml
  • res/qml/WaveformDisplay.qml
  • src/engine/enginemixer.cpp
  • src/engine/enginemixer.h
  • src/mixer/basetrackplayer.cpp
  • src/mixer/basetrackplayer.h
  • src/preferences/dialog/dlgprefwaveform.cpp
  • src/preferences/dialog/dlgprefwaveform.h
  • src/preferences/dialog/dlgprefwaveformdlg.ui
  • src/qml/qmlconfigproxy.cpp
  • src/qml/qmlconfigproxy.h
  • src/test/dlgprefwaveform_test.cpp
  • src/test/interfaceqml_test.cpp
  • src/test/playermanagertest.cpp
  • src/waveform/renderers/waveformwidgetrenderer.cpp
  • src/waveform/renderers/waveformwidgetrenderer.h
  • src/waveform/waveformwidgetfactory.cpp
  • src/waveform/waveformwidgetfactory.h

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 34773428007

Warning

No base build found for commit 6f83181 on pr23/forest/base.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 30.347%

Details

  • Patch coverage: 103 uncovered changes across 5 files (23 of 126 lines covered, 18.25%).

Uncovered Changes

File Changed Covered %
src/preferences/dialog/dlgprefwaveform.cpp 54 0 0.0%
src/waveform/waveformwidgetfactory.cpp 27 0 0.0%
src/qml/qmlconfigproxy.cpp 28 13 46.43%
src/waveform/renderers/waveformwidgetrenderer.cpp 10 5 50.0%
src/waveform/waveformwidgetfactory.h 2 0 0.0%
Total (7 files) 126 23 18.25%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 117586
Covered Lines: 35684
Line Coverage: 30.35%
Coverage Strength: 54407.11 hits per line

💛 - Coveralls

@0cwa

0cwa commented Sep 14, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants