Repository navigation
test(tmx): wait for the pane process before reading its directory - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's
Checksjob fails on every branch since GitHub movedubuntu-latestto ubuntu-26.04, whichships tmux 3.6a.
test_directory_names_are_distinct_and_do_not_expand_tmux_formatsread#{pane_current_path}right after creating a session. tmux reads that value from the pane'sprocess. On the new runner the process had not started in its directory yet, so tmux reported the
server's working directory, the repository root.
The test now polls for up to five seconds until the pane reports its session directory. If the wait
runs out, the assertion message includes tmux's
pane_start_path, the pane's command, and theprocess's real working directory from
/proc, so a real behavior change is distinguishable from aslow start.
A manually dispatched CI run on this branch passed on ubuntu-26.04:
https://github.com/0xA3B/dotfiles/actions/runs/42932655568