Repository navigation
feat: let secondary sources ship executables and completion registries - #123
Merged
Merged
Conversation
The shell hooks select files by path, so shims a secondary source adds under dot_local/bin/work/ were skipped and the gate passed unchecked.
A secondary source can register its own CLIs without taking over config.local.json, which stays the machine-local overlay and merges last.
Secondary-source shims there shadow the real binaries in both fish and zsh. Personal machines have no such directory, so nothing changes there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A secondary source needs to ship its own executables and register its own CLIs for completion generation without writing any target the primary source owns. This PR adds the two primary-side hooks for that, plus a lint gap that the first secondary shims exposed.
generate-completionsnow mergesconfig.json, thenconfig.d/*.jsonin name order, thenconfig.local.json. A secondary source can ship its own drop-in, andconfig.local.jsonstays the machine-local overlay that wins last.PATH.20-work.fishand20-work.zshmove~/.local/bin/workto the front ofPATHwhen the directory exists, so shims there shadow the real binaries. On machines without the directory, nothing changes.dot_local/bin/executable_*only, so a secondary source's shims underdot_local/bin/work/were never checked and the gate passed without looking at them.The
PATHentry and the drop-in directory name no private content. The executables and the drop-in itself live in the secondary source.