Skip to content

feat(engineering): add the retro skill and session scope for skill feedback - #338

Merged
0xA3B merged 3 commits into
mainfrom
feat/retro-skill
Nov 16, 2026
Merged

0xA3B merged 3 commits into
mainfrom
feat/retro-skill

Conversation

@0xA3B

@0xA3B 0xA3B commented Nov 16, 2026

Copy link
Copy Markdown
Owner

The upstream sync in #328 deferred retro until the maintainer decided the shape of a similar skill for this repository. That decision is made: a session retrospective for the agent's environment goes in engineering, and meta:submit-skill-feedback stays the separate workflow for feedback on this marketplace's skills. This change adds the first and connects the two.

engineering:retro

A manual-only skill adapted from Matt Pocock's retro. It reviews agent sessions for moments where a session lost time, made a mistake, or lacked a fact. It then reports findings in severity order, each with a proposed change to the agent's environment: a navigation pointer, an automated check, a review rule, a smaller always-loaded instruction file, a cheaper tool call, or new access to information. It changes nothing; the user decides which findings to act on.

Differences from upstream:

  • Review rules. The repository's REVIEW.md or ## Code Review Rules section replaces upstream's CODING_STANDARDS.md.
  • Instruction files. Upstream keeps AGENTS.md to navigation pointers. Here an always-loaded file also keeps what the implementing agent must know before it acts and no check or reviewer can enforce.
  • Session scope. The default is the current session. When the user names sessions, the skill reads them from the session store of the agent running it. It reads another agent's sessions, such as Codex sessions from a Claude Code session, only from a path the user names, and it does not search the machine for session stores.
  • Skill-owned findings. A finding whose owner is an installed skill gets one line and no proposed edit. When the skill comes from this marketplace and meta is installed, retro recommends meta:submit-skill-feedback.
  • Term. The skill says "finding" where upstream says "candidate", because Candidate has another meaning in plugins/AGENTS.md.

meta:submit-skill-feedback

  • Session scope. The skill takes a sessions argument with the same session-store boundary as retro. It classifies the source of each session as public or private separately, and merges items across sessions only when their classifications match.
  • Recommendation. For an item that does not qualify because repository instructions, repository tooling, or the agent's environment owns it, the skill recommends engineering:retro when engineering is installed.

Both skills are manual-only, so each names the other only as a recommendation for the user to invoke.

engineering:grill-me

One sentence said "harness" where wayfinder says "agent", and the root AGENTS.md lists "harness" as an alias to avoid.

Review notes

  • The session-selection steps appear in both skills. Two plugins cannot share a reference file, and each skill must work without the other plugin installed.
  • add-skill calls for a pressure test of a skill that preserves a safety boundary. It was not run. A failing run would search this machine for session stores, and no isolated context was available that contains that search.
  • Both skills are manual-only and no implicitly invokable skill's description changes, so no trigger evals were run.

Versions

  • engineering 3.2.1 → 3.3.0, for the new skill.
  • meta 1.2.2 → 1.3.0, for the new argument.

Copilot AI lite review requested due to automatic review settings November 16, 2026 01:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T02:10:36.598099Z f784229 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Two active nit findings remain in plugins/engineering/skills/retro/SKILL.md, involving ambiguous grammar and an imprecise section reference that should be corrected.

2 open issues
What changed in this PR

Adds a manual-only engineering:retro skill for reviewing agent sessions and proposing environment improvements, while extending meta:submit-skill-feedback to analyze explicitly selected sessions. The PR also updates related documentation, metadata, versions, and terminology.

Changes:

  • Added engineering:retro, including session-selection boundaries, finding categories, remedy placement, and severity-ordered reporting.
  • Extended meta:submit-skill-feedback with multi-session selection, per-session source classification, recurrence handling, and recommendations for repository-owned feedback.
  • Updated plugin READMEs, marketplace documentation, manifests, versions, and terminology.
File Description
README.md Lists the new retro skill and documents multi-session feedback capture.
plugins/​meta/​skills/​submit-skill-feedback/​SKILL.md Adds session selection, source classification, recurrence handling, and recommendations to use engineering:retro.
plugins/​meta/​README.md Documents the expanded feedback workflow and session scope.
plugins/​meta/​plugin.json Bumps the meta plugin version to 1.3.0.
plugins/​meta/​.claude-plugin/​plugin.json Synchronizes the Claude extension version to 1.3.0.
plugins/​engineering/​skills/​retro/​SKILL.md Adds the session retrospective workflow, environment-improvement guidance, and reporting rules.
plugins/​engineering/​skills/​retro/​agents/​openai.yaml Defines Codex display metadata and manual-only invocation policy for the retro skill.
plugins/​engineering/​skills/​grill-me/​SKILL.md Replaces the avoided “harness” terminology with “agent.”
plugins/​engineering/​README.md Documents the retro workflow and adds it to the engineering skill list.
plugins/​engineering/​plugin.json Bumps the engineering plugin version to 3.3.0 and updates its description.
plugins/​engineering/​.claude-plugin/​plugin.json Synchronizes the Claude extension version and description with the engineering plugin.

Review effort: Lite

Adapt upstream retro as a manual-only review of agent sessions that reports
environment improvements and changes nothing. It reads only the running agent's
own session store unless the user names a path, and it hands findings owned by
a marketplace skill off to meta:submit-skill-feedback.
Copilot AI lite review requested due to automatic review settings November 16, 2026 02:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A critical active issue remains because the guidance does not explicitly prohibit merging sessions across public and private source classifications, risking boundary-crossing evidence.

1 open issue
2 resolved since last review

Review effort: Lite

Add a session-scope argument with the same session-store boundary as
engineering:retro, classify each session's source separately, and recommend
engineering:retro for items the repository or the agent's environment owns.
Copilot AI lite review requested due to automatic review settings November 16, 2026 02:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Approval is deferred because the new session-selection and source-boundary workflows cannot be runtime-tested here, leaving safe historical-session selection, redaction, and public/private destination separation unverified.

No open issues 🎉

1 resolved since last review

Review effort: Lite

@0xA3B
0xA3B merged commit 15b9481 into main Nov 16, 2026
2 checks passed
@0xA3B
0xA3B deleted the feat/retro-skill branch November 16, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants