Skip to content

fix: make the uv script mirror a default and align draft paths - #348

Merged
0xA3B merged 2 commits into
mainfrom
fix/skill-feedback-341-343
Nov 16, 2026
Merged

0xA3B merged 2 commits into
mainfrom
fix/skill-feedback-341-343

Conversation

@0xA3B

@0xA3B 0xA3B commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Two feedback issues each reported an instruction that an agent followed as written and that still
produced the wrong result. This change rewords both instructions.

Mirror of a script's dependencies (engineering:dependency-policy)

The uv reference gave the mirror of an unlocked script's inline dependencies only as a way to make
CI test their range. A session that rewrote a repository's dependency policy as the Precedence
section directs kept only the rules that differ from the skill, and it removed the repository's own
mirror rule. After that edit, nothing required the mirror, and CI would keep passing without testing
the range that each machine resolves.

The reference now states the mirror as the default:

  • It applies when pyproject.toml has a [project] table. A repository of standalone scripts has
    no table to mirror into.
  • It covers each of the script's dependencies. The old sentence could be read as covering only the
    0.x dependencies.

A script with a <script>.lock file still needs no mirror.

Directory for drafts (git:create-pr, git:babysit-pr)

Both skills kept their files in "a directory named for the topic branch". A session read that as
.local/type-purpose/ for the branch type/purpose. git:merge-pr ties a file to its change
request only when the path holds the full branch name as a directory path, so a later session could
not prove the tie and would have to ask the user before it deleted the draft.

Both skills now give the path in the form that git:merge-pr matches, such as feat/retry/ for the
branch feat/retry. The rule in git:merge-pr is unchanged, because a looser test would let its
cleanup delete more files.

Validation

I ran the description step of create-pr in a scratch repository on the branch fix/retry-timeout,
once with each wording on each agent:

Wording Claude Code Codex
Old .local/fix-retry-timeout/pr-body.md .local/fix/retry-timeout/pr-body.md
New .local/fix/retry-timeout/pr-body.md .local/fix/retry-timeout/pr-body.md

No run tested the new mirror sentence.

Closes #341
Closes #343

The uv reference gave the mirror of an unlocked script's dependencies
only as a way to make CI test their range. A repository that follows the
Precedence section keeps only the rules that differ from the skill, so
it dropped its own mirror rule and nothing required the mirror any more,
while CI kept passing without testing the range machines resolve.

The mirror is now the default wherever `pyproject.toml` has a
`[project]` table, and it covers each of the script's dependencies.

Refs: #341
create-pr and babysit-pr kept their files in "a directory named for the
topic branch", which a session read as `type-purpose` for the branch
`type/purpose`. merge-pr ties a file to its change request only when the
path holds the full branch name as a directory path, so its cleanup could
not prove the tie for that draft.

Both skills now give the path in the form merge-pr matches.

Refs: #343
Copilot AI lite review requested due to automatic review settings November 16, 2026 06:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T06:16:20.203644Z cf4591b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, so the documented path and dependency-guidance updates are ready to proceed.

No open issues 🎉

What changed in this PR

This PR clarifies uv dependency-mirroring guidance and aligns Git workflow draft paths with git:merge-pr cleanup rules while bumping the affected plugin patch versions.

Changes:

  • Updates create-pr and babysit-pr to preserve the full topic-branch path in scratch directories.
  • Revises uv guidance to mirror applicable script dependencies into [project].dependencies.
  • Bumps the Git and Engineering plugin versions and synchronizes their Claude extensions.
File Description
plugins/​git/​skills/​create-pr/​SKILL.md Aligns draft storage paths with the full topic-branch path.
plugins/​git/​skills/​babysit-pr/​SKILL.md Aligns poll-log and related artifact paths with the full topic-branch path.
plugins/​git/​plugin.json Bumps the portable Git plugin patch version.
plugins/​git/​.claude-plugin/​plugin.json Synchronizes the Claude Git extension version with the portable manifest.
plugins/​engineering/​skills/​dependency-policy/​references/​python-uv.md Clarifies dependency-mirroring guidance for uv scripts.
plugins/​engineering/​plugin.json Bumps the portable Engineering plugin patch version.
plugins/​engineering/​.claude-plugin/​plugin.json Synchronizes the Claude Engineering extension version with the portable manifest.

Review effort: Lite

@0xA3B
0xA3B merged commit 69d3a86 into main Nov 16, 2026
2 checks passed
@0xA3B
0xA3B deleted the fix/skill-feedback-341-343 branch November 16, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants