Repository navigation
fix: make the uv script mirror a default and align draft paths - #348
Merged
Merged
Conversation
The uv reference gave the mirror of an unlocked script's dependencies only as a way to make CI test their range. A repository that follows the Precedence section keeps only the rules that differ from the skill, so it dropped its own mirror rule and nothing required the mirror any more, while CI kept passing without testing the range machines resolve. The mirror is now the default wherever `pyproject.toml` has a `[project]` table, and it covers each of the script's dependencies. Refs: #341
create-pr and babysit-pr kept their files in "a directory named for the topic branch", which a session read as `type-purpose` for the branch `type/purpose`. merge-pr ties a file to its change request only when the path holds the full branch name as a directory path, so its cleanup could not prove the tie for that draft. Both skills now give the path in the form merge-pr matches. Refs: #343
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, so the documented path and dependency-guidance updates are ready to proceed.
No open issues 🎉
What changed in this PR
This PR clarifies uv dependency-mirroring guidance and aligns Git workflow draft paths with git:merge-pr cleanup rules while bumping the affected plugin patch versions.
Changes:
- Updates
create-prandbabysit-prto preserve the full topic-branch path in scratch directories. - Revises uv guidance to mirror applicable script dependencies into
[project].dependencies. - Bumps the Git and Engineering plugin versions and synchronizes their Claude extensions.
| File | Description |
|---|---|
| plugins/git/skills/create-pr/SKILL.md | Aligns draft storage paths with the full topic-branch path. |
| plugins/git/skills/babysit-pr/SKILL.md | Aligns poll-log and related artifact paths with the full topic-branch path. |
| plugins/git/plugin.json | Bumps the portable Git plugin patch version. |
| plugins/git/.claude-plugin/plugin.json | Synchronizes the Claude Git extension version with the portable manifest. |
| plugins/engineering/skills/dependency-policy/references/python-uv.md | Clarifies dependency-mirroring guidance for uv scripts. |
| plugins/engineering/plugin.json | Bumps the portable Engineering plugin patch version. |
| plugins/engineering/.claude-plugin/plugin.json | Synchronizes the Claude Engineering extension version with the portable manifest. |
Review effort: Lite
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two feedback issues each reported an instruction that an agent followed as written and that still
produced the wrong result. This change rewords both instructions.
Mirror of a script's dependencies (
engineering:dependency-policy)The uv reference gave the mirror of an unlocked script's inline dependencies only as a way to make
CI test their range. A session that rewrote a repository's dependency policy as the Precedence
section directs kept only the rules that differ from the skill, and it removed the repository's own
mirror rule. After that edit, nothing required the mirror, and CI would keep passing without testing
the range that each machine resolves.
The reference now states the mirror as the default:
pyproject.tomlhas a[project]table. A repository of standalone scripts hasno table to mirror into.
0.x dependencies.
A script with a
<script>.lockfile still needs no mirror.Directory for drafts (
git:create-pr,git:babysit-pr)Both skills kept their files in "a directory named for the topic branch". A session read that as
.local/type-purpose/for the branchtype/purpose.git:merge-prties a file to its changerequest only when the path holds the full branch name as a directory path, so a later session could
not prove the tie and would have to ask the user before it deleted the draft.
Both skills now give the path in the form that
git:merge-prmatches, such asfeat/retry/for thebranch
feat/retry. The rule ingit:merge-pris unchanged, because a looser test would let itscleanup delete more files.
Validation
I ran the description step of
create-prin a scratch repository on the branchfix/retry-timeout,once with each wording on each agent:
.local/fix-retry-timeout/pr-body.md.local/fix/retry-timeout/pr-body.md.local/fix/retry-timeout/pr-body.md.local/fix/retry-timeout/pr-body.mdNo run tested the new mirror sentence.
Closes #341
Closes #343