Repository navigation
fix(ffi): dispatch P-256 signing to the matching ECDSA curve - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P-256 ECDSA shares failed in
tss_sign_newwithProtocolMismatchbecause all DKLs23 sessions used the secp256k1 constructor. Dispatch by ciphersuite so P-256 usesnew_dkls_r1and secp256k1 retainsnew_dkls.This staging branch merges #5 and adds separate follow-up commits for formatting, C ABI regression tests, the benchmark dependency audit fix, and reproducible fuzz dependency resolution. Both ECDSA curves exercise two-party DKG, signing, signature verification, changed-message rejection, and key-handle ownership.
Validation:
ProtocolMismatch; secp256k1 passes.crossbeam-epochfrom 0.9.18 to 0.9.20 to resolve RUSTSEC-2026-0204.cargo auditnow reports zero vulnerabilities; existing unmaintained/unsound/yanked dependency warnings remain.Closes #4. Supersedes #5.