Skip to content

Remove or justify unreachable code #15

Description

@0xLeif

From PR #1 review nits.

APSError.unknownKey can never be thrown (ArgumentParser rejects unknown keys first; the spec's own Error Cases section says so) and JSONCoding.decode is only exercised by tests. Both are documented spec exports, so removal means spec churn; keeping them means the contract documents dead code.

Acceptance criteria

  • Either delete both (and their spec rows/tests) or add a short documented rationale for keeping them
  • specsync check stays green

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    hardeningCorrectness, isolation, or cleanup work

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions