Repository navigation
TTY-aware output under the git porcelain rule (Closes #33) - #53
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
5 tasks
Review (agent:cursor) — tested locallyVerdict: Approve after SpecSync renumber (post-#50). Tested
Required before merge
Merge orderSafe soon after #50. Orthogonal enough to #54/#55, but rebase for SpecSync evidence churn. |
This was referenced Jul 19, 2026
- new TTY.swift: isatty detection, NO_COLOR-aware Style, aligned table - keys: aligned bold-header table on TTY, byte-stable TSV when piped, --quiet for names only - JSON pretty on TTY, compact when piped (gh rule) via CLIOutput.encodeJSON and JSONCoding.encodeAuto (dump keeps the injected dependency) - watch --json aliases --jsonl - README documents output modes and --generate-completion-script - tests (4 new) + smoke (piped-plain, alias, quiet, compact greps); specs in lockstep - SpecSync CHG-0021 accepted; evidence rebound for shared changes (audited reopens, actor 0xLeif)
FileHandle.fileDescriptor is unavailable on Windows; use MSVCRT _isatty/_fileno via ucrt there.
Piped JSON is now compact (gh rule); the PowerShell smoke greps still expected the pretty form.
cursor
Bot
force-pushed
the
kimi/issue-33-tty-output
branch
from
July 19, 2026 12:59
6601523 to
ea7599b
Compare
|
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
Summary
TTY-aware output under the git porcelain rule (design decision 5, minimal chrome): human output may be pretty, machine output is a frozen contract.
TTY.swift: isatty detection,NO_COLOR-awareStyle(bold/red/green, identity when disabled), column-aligningtable(header:rows:)keys: aligned bold-header table on a TTY; byte-stable TSV when piped (verified byte-for-byte); new--quietprints key names onlyCLIOutput.encodeJSONfor--jsonpayloads andJSONCoding.encodeAutofordump(keeps the injected dependency — the DI demo stays honest)watch --jsonis now an alias for--jsonl--generate-completion-script bash|zsh|fishdocumentationMachine shapes stay additive-only; only whitespace and (TTY-only) ANSI adapt. Error-path coloring is deliberately out of scope here: the error contract PR (#50) owns the fail path when it lands.
Verification (local, worktree)
swift buildclean; 44 tests (4 new: table alignment, style identity off-TTY, compact JSON off-TTY for both encoders), 0 failuressmoke.shgreen incl. new assertions: pipedkeysis TSV with zero ANSI,keys --quiet,watch --jsonalias, all JSON greps moved to the compact contractspecsync check --force7/7 files 100%,specsync change check20 active valid,fledge lanes run verifygreenkeysbyte-dumped (TSV, no ESC), pipeddumpsingle-line, TTY paths inspectedSpecSync
Merge note
Overlaps #50 (CLIOutput/Aps error paths) and #51 (README agent section) textually but not semantically; whichever merges second gets the usual rebase + rebind pass, which I will happily run.