Update to last plonky2 version, update recursive logic and add a recursive test#2
Open
arnaucube wants to merge 3 commits into
Open
Update to last plonky2 version, update recursive logic and add a recursive test#2arnaucube wants to merge 3 commits into
arnaucube wants to merge 3 commits into
Conversation
and update the Semaphore link to the current one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo has been very useful to start to get familiar with plonky2, so big thanks for creating it 🙌
While using it, had some issues to compile it, so ended up porting it to the latest plonky2 version.
Also found that the recursive part was not registering public inputs and there was no test for the recursive part, so added it too.
As a last thing, since I was figuring out how things work along the way, I've added inline comments that try to explain what's going on on some method calls. I left the comments hoping that they might be useful for other people, but if you prefer to not have them, they are added only in the 3rd commit and we can revert it removing them.
Also, I'm just starting to get familiar with plonky2, so there might be parts of the code that are incorrect, including the added comments, if so, I'm interested to learn about it.