fix(ios): make conversation back button work again - #315
Closed
DatScreamer wants to merge 2 commits into
Closed
DatScreamer wants to merge 2 commits into
DatScreamer wants to merge 2 commits into
Conversation
Owner
|
Landed in #319 (merged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313
The conversation back button introduced in cf82de5 ("ui: move conversation controls into composer") does nothing because it calls
dismiss()on a path-drivenNavigationStack(a no-op for programmatically-pushed routes), and its hit area is only the thin chevron glyph.Changes:
popCurrentRoute(), which pops the path-driven navigation stack — matching how every other pop in this codebase works and how the Android side of cf82de5 pops its nav stack..contentShape(Circle())so the entire 40x40 glass circle is tappable, matching SavedAppDetailView.Verification:
make ios(signed package lane), installed on iPhone 17 Pro simulator.Before cf82de5 the conversation used the native nav-bar back button (shipped in 2.0); this restores equivalent behavior while keeping the custom glass top-bar design.