Skip to content

Fix Qwen3-ASR language option propagation #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xShug0 merged 1 commit into from
Aug 15, 2026
+12 −0
Merged

Fix Qwen3-ASR language option propagation #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/models/qwen3_asr/session.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,9 @@ Qwen3ASRRequest Qwen3ASRSession::make_request(const runtime::TaskRequest & reque
out.context = request.text_input->text;
out.language = request.text_input->language;
}
if (const auto value = runtime::find_option(request.options, {"language"})) {
out.language = *value == "Auto" ? "" : *value;
}
if (const auto value = runtime::parse_int_option(request.options, {"max_tokens"})) {
out.generation.max_new_tokens = *value;
if (out.generation.max_new_tokens <= 0) {
Expand Down
9 changes: 9 additions & 0 deletions tests/unittests/test_cli_request_options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,21 @@ void test_unsafe_integer_numbers_are_not_silently_rounded() {
require_seed_rejected(rounded);
}

void test_audio_only_language_is_request_option() {
const char * argv[] = {"audiocpp_cli", "--task", "asr", "--family", "qwen3_asr", "--language", "en"};
const auto request = minitts::cli::build_request_from_cli(7, const_cast<char **>(argv));

engine::test::require(!request.text_input.has_value(), "audio-only language does not synthesize text input");
engine::test::require_eq(request.options.at("language"), std::string("en"), "audio-only language request option");
}

} // namespace

int main() {
test_large_safe_integer_numbers_stay_decimal();
test_float_numbers_keep_json_formatting();
test_unsafe_integer_numbers_are_not_silently_rounded();
test_audio_only_language_is_request_option();
std::cout << "cli_request_options_test passed\n";
return 0;
}
Loading