Skip to content

Issue #38 (partial): Unicode rename/copy fixes and prompt ownership#41

Merged
0xeb merged 1 commit intomainfrom
work
Mar 4, 2026
Merged

Issue #38 (partial): Unicode rename/copy fixes and prompt ownership#41
0xeb merged 1 commit intomainfrom
work

Conversation

@0xeb
Copy link
Owner

@0xeb 0xeb commented Mar 4, 2026

Summary

This PR delivers a partial fix for #38 focused on Unicode rename/copy/paste reliability and prompt ownership behavior.

What is fixed

  • Unicode copy-name generation now checks collisions correctly in wide paths.
  • Best-fit ANSI fallback detection is enforced before taking ANSI rename/create paths.
  • Quick Rename retry flow preserves the latest Unicode value across retries.
  • Viewer Ctrl+F "not found" prompts are re-parented to the viewer window.
  • Delete prompt default remains intentional (Yes on Enter), with policy centralized.

Known remaining gaps

Issue linkage

Validation

  • Built locally: cmake --build build --target sally --config Debug
  • Manual checks performed for rename/copy/paste and viewer find prompt parenting.

@0xeb 0xeb marked this pull request as ready for review March 4, 2026 05:52
@0xeb 0xeb merged commit b4858e4 into main Mar 4, 2026
11 checks passed
@0xeb 0xeb deleted the work branch March 4, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant