Skip to content

Fixed time display and hash display #20

Description

@gengxuelei

fix time display

https://github.com/seanjameshan/blockchain-cli/blob/master/lib/cli/util/table.js#L26
the function 'toUTCString' should be changed to 'toISOString' (the toUTCString function will lose milliseconds that lead to sha256(block) different)
It's best to get rid of 'timeStamp/1000' but use timeStamp directly

fix hash display

https://github.com/seanjameshan/blockchain-cli/blob/master/lib/cli/util/table.js#L10
this line should be changed to 'colWidths:[20,66]' to show hash fully :
#13

make judgment more precise

https://github.com/seanjameshan/blockchain-cli/blob/master/lib/blockchain/index.js#L128
this line should be changed to 'return i >= this.difficulty;' ; the hash should contains at least difficulty zero

show mining time:

https://github.com/seanjameshan/blockchain-cli/blob/master/lib/blockchain/index.js#L111
before L111 while there should have a time:

var _beginTime = new Date();

after L116 spinner.clear(); there show have a tips:

console.log("Mining new block use time: ", new Date() - _beginTime, "ms")

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions